Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the GA4 Activation Banner to the Entity Dashboard #5673

Closed
techanvil opened this issue Aug 10, 2022 · 8 comments
Closed

Add the GA4 Activation Banner to the Entity Dashboard #5673

techanvil opened this issue Aug 10, 2022 · 8 comments
Labels
P1 Medium priority Type: Feature New feature

Comments

@techanvil
Copy link
Collaborator

techanvil commented Aug 10, 2022

Feature Description

Show the GA4 Activation Banner on the Entity Dashboard.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The GA4 Activation Banner should be included on the Entity Dashboard, when the ga4ActivationBanner feature flag is enabled.

Implementation Brief

  • In assets/js/components/notifications/EntityBannerNotifications.js:
    • Use the useFeature hook passing the ga4ActivationBanner string to it and assign it to a variable named ga4ActivationBannerEnabled.
    • In the return statement, render the <ActivationBanner /> component (assets/js/modules/analytics-4/components/dashboard/ActivationBanner) only if ga4ActivationBannerEnabled is truthy.

Test Coverage

  • No tests need to be added/updated.

QA Brief

  • With the ga4ActivationBanner feature flag enabled, navigate to the entity dashboard
  • Ensure that the ga4 activation banner renders correctly
  • Navigate to the entity dashboard without the feature flag enabled
  • The component should not be present.

Changelog entry

  • Add the Google Analytics 4 Activation Banner to the Entity Dashboard.
@techanvil techanvil added P1 Medium priority Type: Feature New feature labels Aug 10, 2022
@aaemnnosttv
Copy link
Collaborator

@techanvil I've tweaked the language to hopefully avoid misinterpretation that the banner should be displayed/visible when the feature flag is enabled as it has its own logic for determining that as well which is still relevant of course.

@techanvil
Copy link
Collaborator Author

Good shout @aaemnnosttv, thanks!

@nfmohit nfmohit self-assigned this Aug 10, 2022
@nfmohit
Copy link
Collaborator

nfmohit commented Aug 10, 2022

@techanvil I believe including the GA4 Activation Banner to the Main Dashboard has been already done at #5270. Do we need to update the ACs?

I have added the IB for the Entity Dashboard.

@techanvil techanvil changed the title Add the GA4 Activation Banner to the Main and Entity Dashboard Add the GA4 Activation Banner to the Entity Dashboard Aug 11, 2022
@techanvil
Copy link
Collaborator Author

Thanks @nfmohit, not sure how I missed that. I've updated the rest of the issue accordingly. Cheers!

@nfmohit
Copy link
Collaborator

nfmohit commented Aug 11, 2022

Thank you @techanvil!

@nfmohit nfmohit removed their assignment Aug 11, 2022
@eugene-manuilov eugene-manuilov self-assigned this Aug 11, 2022
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Aug 11, 2022
@maciejost maciejost assigned maciejost and unassigned maciejost Aug 12, 2022
@techanvil techanvil assigned techanvil and maciejost and unassigned techanvil Aug 12, 2022
@maciejost maciejost assigned techanvil and unassigned maciejost Aug 14, 2022
@techanvil
Copy link
Collaborator Author

@makiost I tweaked the QAB to explicitly mention the entity dashboard rather than just the dashboard.

@techanvil techanvil removed their assignment Aug 15, 2022
@mohitwp
Copy link
Collaborator

mohitwp commented Aug 17, 2022

QA Update ✅

  • Verified when ga4ActivationBanner feature flag enabled.
  • On entity dashboard - ga4 activation banner renders correctly
  • Verified when ga4ActivationBanner feature flag disabled.
  • On entity dashboard - ga4 activation banner is not present.
Recording.136.mp4

@mohitwp mohitwp removed their assignment Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Type: Feature New feature
Projects
None yet
Development

No branches or pull requests

7 participants