-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the GA4 Activation Banner to the Entity Dashboard #5673
Comments
@techanvil I've tweaked the language to hopefully avoid misinterpretation that the banner should be displayed/visible when the feature flag is enabled as it has its own logic for determining that as well which is still relevant of course. |
Good shout @aaemnnosttv, thanks! |
@techanvil I believe including the GA4 Activation Banner to the Main Dashboard has been already done at #5270. Do we need to update the ACs? I have added the IB for the Entity Dashboard. |
Thanks @nfmohit, not sure how I missed that. I've updated the rest of the issue accordingly. Cheers! |
Thank you @techanvil! |
IB ✔️ |
@makiost I tweaked the QAB to explicitly mention the entity dashboard rather than just the dashboard. |
QA Update ✅
Recording.136.mp4 |
Feature Description
Show the GA4 Activation Banner on the Entity Dashboard.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
ga4ActivationBanner
feature flag is enabled.Implementation Brief
assets/js/components/notifications/EntityBannerNotifications.js
:useFeature
hook passing thega4ActivationBanner
string to it and assign it to a variable namedga4ActivationBannerEnabled
.<ActivationBanner />
component (assets/js/modules/analytics-4/components/dashboard/ActivationBanner
) only ifga4ActivationBannerEnabled
is truthy.Test Coverage
QA Brief
ga4ActivationBanner
feature flag enabled, navigate to the entity dashboardChangelog entry
The text was updated successfully, but these errors were encountered: