"Flatten" options for Thank with Google placement options in settings

[tofumatt]

Feature Description

Follow-up to #5623; the original Figma mocks showed a Manual placement option with sub-options. But when implemented the manual button did nothing, so as a follow-up I proposed changing it to a heading but keeping it inline with the mocks otherwise.

As pointed out by @felixarntz here: #5623 (comment), this is actually a bit odd. Evan pointed out that we could flatten the options which seems to be the cleanest/simplest/best UX approach: #5623 (comment)

It could even be good to remove the "manual" prefix as it can make the text harder to scan and is implied, eg:

(A draft PR for this change is here: #5684.)

(Leaving this issue in AC pending UX review. Please don't move the IB yet.)

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The "placement" setting for Thank with Google should be changed to have only four options, all selectable:
  • Auto
    The prompt is automatically placed where it will perform best
  • Above the post
    The prompt is placed before the main post content
  • Below the post
    The prompt is placed after the main post content
  • Below the first paragraph
    The prompt is placed after the first paragraph in the main post content
• The "Manual" heading should be removed, eg all choices should be in a flat hierarchy.

Implementation Brief

• Remove the "Manual" radio option, flatten the suboptions to be at the same level as "auto", and change each "sub-option" to be a regular radio option, the same as "Auto".
• Remove unneeded .googlesitekit-twg-position-radio__suboptions and .googlesitekit-twg-position-radio__option h5/.googlesitekit-twg-position-radio__option p styles, since the "non-button" radio is removed

Test Coverage

• No new tests needed; the behaviour will be the same just without the "fake radio button header" and with different text.
• VRTs may need updating.

QA Brief

• Go to Thank with Google settings edit and click the Continue module setup link.
• Click on the Customize Thank with Google button.
• Click on the Fixed Type.
• Ensure the "placement" setting for Thank with Google should be changed to have only four options.
• Ensure there are no sub-options.

Changelog entry

• Flatten Thank with Google placement options in settings.

[tofumatt]

Seba from UX said the proposed changes here look good, so we have UX sign-off.

@felixarntz I think we can move this to IB given UX approval; if you think so too feel free to move this to IB and assign me (since I have a proof-of-concept already mocked up).

[felixarntz]

Thanks @tofumatt, LGTM!

[eugene-manuilov]

IB ✔️

[mohitwp]

QA Update ✅

Verified 👍

• Verified TwG "placement" setting for Thank with Google now changed to have only four options.
• The "Manual" heading is now removed.
• Able to select all radio buttons.
• Selected option is showing under settings>connected services>TwG details.

Note : Under TwG settings, prominence label is showing for position. I will create a separate ticket for this.