Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove infrastructure related to storage and synchronization of user input settings between service and plugin #5899

Closed
kuasha420 opened this issue Sep 25, 2022 · 3 comments
Labels
P1 Medium priority Rollover Issues which role over to the next sprint Type: Enhancement Improvement of an existing feature

Comments

@kuasha420
Copy link
Contributor

kuasha420 commented Sep 25, 2022

Feature Description

Once #5898 is implemented and the User Input answers are being stored and read from the Site's database, any leftover code related to storage and synchronization of user input settings between Site Kit service and plugin should be removed.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Code related to the storage, retrieval, and synchronization of user input answers on the Site Kit service should be removed.

Implementation Brief

  • In includes/Core/Util/User_Input_Settings.php, remove the following:
    • Remove the TRANSIENT_NAME constant.
    • Remove the transients and user_transients properties and update the User_Input_Settings::__construct method to remove the transient and user_transient arguments.
    • Remove is_connected_to_proxy, sync_with_proxy, are_settings_empty, cache_settings, get_settings and set_settings methods.
  • Note: Deleting the User_Input_State class and its references will be implemented in Simplify logic around user input completion state #5900.

Test Coverage

  • Remove the existing test cases for the above-removed methods.

QA Brief

Changelog entry

@kuasha420 kuasha420 added the Type: Enhancement Improvement of an existing feature label Sep 25, 2022
@kuasha420 kuasha420 self-assigned this Sep 25, 2022
@kuasha420 kuasha420 assigned aaemnnosttv and unassigned kuasha420 Oct 12, 2022
@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Oct 12, 2022

  • The code related to storage and synchronization of user input answers should be removed from the code base.

@kuasha420 let's make this more specific to the SK service as described. This is a bit too loose as defined.

I made this change above as it's a rather simple one to not block this 👍

@aaemnnosttv aaemnnosttv added the P0 High priority label Oct 12, 2022
@aaemnnosttv aaemnnosttv removed their assignment Oct 12, 2022
@eclarke1 eclarke1 added P1 Medium priority and removed P0 High priority labels Oct 14, 2022
@hussain-t hussain-t self-assigned this Oct 18, 2022
@hussain-t hussain-t removed their assignment Oct 19, 2022
@tofumatt tofumatt self-assigned this Oct 24, 2022
@tofumatt
Copy link
Collaborator

IB ✅

@tofumatt tofumatt removed their assignment Oct 25, 2022
@hussain-t hussain-t self-assigned this Oct 30, 2022
@FlicHollis FlicHollis added the Rollover Issues which role over to the next sprint label Nov 21, 2022
@hussain-t
Copy link
Collaborator

The User_Input_Settings has been renamed to User_Input, and most of the infrastructure code related to storage has been removed as part of #5898. The remaining part is the are_settings_empty method, its usage, and test cases. IMO, it should be wise to remove it as part of #5900 and close this issue because some of the uses of the are_settings_empty method will be removed in 5900.

cc: @kuasha420 @nfmohit @jimmymadon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Rollover Issues which role over to the next sprint Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

6 participants