-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove infrastructure related to storage and synchronization of user input settings between service and plugin #5899
Comments
@kuasha420 let's make this more specific to the SK service as described. This is a bit too loose as defined. I made this change above as it's a rather simple one to not block this 👍 |
IB ✅ |
The |
Feature Description
Once #5898 is implemented and the User Input answers are being stored and read from the Site's database, any leftover code related to storage and synchronization of user input settings between Site Kit service and plugin should be removed.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
includes/Core/Util/User_Input_Settings.php
, remove the following:TRANSIENT_NAME
constant.transients
anduser_transients
properties and update theUser_Input_Settings::__construct
method to remove thetransient
anduser_transient
arguments.is_connected_to_proxy
,sync_with_proxy
,are_settings_empty
,cache_settings
,get_settings
andset_settings
methods.User_Input_State
class and its references will be implemented in Simplify logic around user input completion state #5900.Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: