Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally render GA4 metrics on SK dashboards #6220

Closed
aaemnnosttv opened this issue Nov 29, 2022 · 3 comments
Closed

Conditionally render GA4 metrics on SK dashboards #6220

aaemnnosttv opened this issue Nov 29, 2022 · 3 comments
Labels
Exp: SP P0 High priority Type: Enhancement Improvement of an existing feature

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Nov 29, 2022

Feature Description


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When the ga4Reporting feature flag is enabled, the widgets on the SK dashboard should display their GA4 variants (created in previous issues) instead of UA components

Implementation Brief

  • Using assets/js/modules/analytics/index.js,
    • Check if the ga4Reporting feature flag is enabled via the isFeatureEnabled function.
    • If the above is true, render
      • DashboardAllTrafficWidgetGA4 instead of DashboardAllTrafficWidget.
      • DashboardOverallPageMetricsWidgetGA4 instead of DashboardOverallPageMetricsWidget.
      • ModulePopularPagesWidgetGA4 instead of ModulePopularPagesWidget.
  • Using assets/js/modules/search-console/index.js,
    • Render SearchFunnelWidgetGA instead of SearchFunnelWidget if ga4Reporting feature flag is enabled.

Test Coverage

  • No new tests to be added.

QA Brief

  • Configure Analytics with GA4 and enable ga4reporting.
  • Check the SK Dashboard Widget. It should have the DashboardAllTrafficWidgetGA4, DashboardOverallPageMetricsWidgetGA4, ModulePopularPagesWidgetGA4, and SearchFunnelWidgetGA4 instead of the non-ga4 versions.

Changelog entry

  • Update Analytics and Search Console widgets to use GA4 versions if the feature flag is enabled for the site.
@aaemnnosttv aaemnnosttv self-assigned this Nov 29, 2022
@aaemnnosttv aaemnnosttv added P1 Medium priority Type: Enhancement Improvement of an existing feature labels Nov 29, 2022
@aaemnnosttv aaemnnosttv removed their assignment Dec 2, 2022
@asvinb asvinb assigned asvinb and unassigned asvinb Dec 13, 2022
@techanvil techanvil self-assigned this Dec 19, 2022
@techanvil
Copy link
Collaborator

IB ✅

@eugene-manuilov
Copy link
Collaborator

@kuasha420, could you, please, add QAB?

@kuasha420 kuasha420 assigned wpdarren and unassigned kuasha420 Mar 8, 2023
@wpdarren
Copy link
Collaborator

wpdarren commented Mar 8, 2023

QA Update: ✅

Verified:

  • With ga4Reporting feature flag enabled
    • The DashboardAllTrafficWidgetGA4, DashboardOverallPageMetricsWidgetGA4, ModulePopularPagesWidgetGA4, and SearchFunnelWidgetGA4 appear on the main/entity dashboard instead of the non-ga4 versions.

For additional testing, I tested the view only dashboard to ensure that the same GA4 metrics were appearing with the feature flag enabled.

  • With ga4Reporting feature flag disabled
    • The main/entity dashboard displays the non-ga4 versions.
Screenshots

image
image
image
image

@wpdarren wpdarren removed their assignment Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp: SP P0 High priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

8 participants