Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isGA4DashboardView selector #6542

Closed
nfmohit opened this issue Feb 7, 2023 · 1 comment
Closed

Update isGA4DashboardView selector #6542

nfmohit opened this issue Feb 7, 2023 · 1 comment
Labels
Type: Enhancement Improvement of an existing feature

Comments

@nfmohit
Copy link
Collaborator

nfmohit commented Feb 7, 2023

Feature Description

Note: This shall only be implemented to be released as a part of the Site Kit update/release going right after UA has a zero-data state.

As a part of the Site Kit update/release going right after UA has a zero-data state, the isGA4DashboardView selector (being implemented in #6541) should be updated so that if GA4 is connected, it should unconditionally return true. Since Site Kit will automatically switch to the GA4 dashboard view at this point, this selector returning true will not require us to change the logic immediately and give us a generous amount of time to remove the selector and the UA module overall.

Here is the relevant part of the design doc.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@nfmohit nfmohit added the Type: Enhancement Improvement of an existing feature label Feb 7, 2023
@nfmohit
Copy link
Collaborator Author

nfmohit commented Feb 8, 2023

Closing in favour of #6549.

@nfmohit nfmohit closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant