Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of permissions to a shared destination should be highlighted to the user #6770

Closed
mxbclang opened this issue Mar 23, 2023 · 2 comments
Labels
Module: Analytics Google Analytics module related issues P2 Low priority Type: Enhancement Improvement of an existing feature

Comments

@mxbclang
Copy link

Feature Description

To recreate this scenario, setup a Google tag which points to a shared destination (a property owned by another Google user that has been shared with the current Google user), and use this tag in Site Kit (select that property in Analytics settings).

Then, remove the permission for that property.

When the check for a change in Google tag mapping occurs, no notification is shown to the user, although an error is displayed in the JS console.

image

Furthermore, the GA4 dropdowns are blank on the Settings page, with no error or other message displayed to the user, but another error in the console:

image

The tag setting itself is unchanged, with the gtag still added to the source code with the same tag ID.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@mxbclang mxbclang added P2 Low priority Type: Enhancement Improvement of an existing feature Module: Analytics Google Analytics module related issues labels Mar 23, 2023
@aaemnnosttv
Copy link
Collaborator

I believe this has been somewhat addressed and there is now inline feedback. See https://google.github.io/site-kit-wp/storybook/develop/?path=/story/modules-analytics-settings-settingsedit--property-not-available

Anything more to address here?

@aaemnnosttv
Copy link
Collaborator

Closing as this has been resolved in #6763

@aaemnnosttv aaemnnosttv closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Analytics Google Analytics module related issues P2 Low priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants