-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fatal error on clicking engagement rate and unique visitor from search data when site is in zero data state. #6788
Comments
It might be worth retesting this once the PR for #6623 has been merged... |
This looks like the same issue that we had in the UA version in #6587, it looks like the fix there didn't get ported to the GA4 version though as mentioned in the IB (https://github.com/google/site-kit-wp/pull/6606/files). |
Taking a closer look here, this seems to be more about the zero state rather than gathering, which seems to work correctly. Could be #6623 is related here as well, but we can at least provide the AC. |
FYI @eclarke1 I've scheduled this for Sprint 99 as we've flagged it as a known issue for Bug Bash: https://app.asana.com/0/1204237371873197/1204290577888659/f |
As the PR for #6623 has now been merged, I've checked this on |
Thanks @techanvil – once confirmed that this is no longer an issue, we can close this as a duplicate since nothing was actually done against this issue. |
QA Update
|
QA Update ✅
Recording.316.mp4 |
Bug Description
When site is in zero data state and under GA4 dashboard view then on clicking "unique visitors from search" and Conversions data creates Fatal error on Main dashboard.
On entity dashboard, clicking on "unique visitors from search" and "engagement rate" creates a fatal error.
Steps to reproduce
googlesitekit.api.set('modules', 'analytics', 'settings', {'dashboardView': 'google-analytics-4'})
Screenshots
Additional Context
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: