Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code from Analytics_4 class. #6834

Closed
techanvil opened this issue Apr 7, 2023 · 3 comments
Closed

Remove unused code from Analytics_4 class. #6834

techanvil opened this issue Apr 7, 2023 · 3 comments
Labels
Exp: SP fixed Module: Analytics Google Analytics module related issues Type: Enhancement Improvement of an existing feature

Comments

@techanvil
Copy link
Collaborator

techanvil commented Apr 7, 2023

Feature Description

In the PR #6790, the GET:report handling was extracted from the Analytics_4 class. However in a subsequent merge, the validate_shared_report_metrics() and validate_shared_report_dimensions() methods have been restored to the class. These are unused and should be removed.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The unused validate_shared_report_metrics() and validate_shared_report_dimensions() methods should be removed from the Analytics_4 class.
  • It looks like this is all that's needed but the Analytics_4 class should be reviewed for any other accidental merge results.

Implementation Brief

Test Coverage

  • N/A

QA Brief

  • N/A

Changelog entry

  • N/A
@techanvil techanvil added Module: Analytics Google Analytics module related issues P1 Medium priority Type: Enhancement Improvement of an existing feature labels Apr 7, 2023
@eugene-manuilov eugene-manuilov self-assigned this Apr 12, 2023
@eugene-manuilov eugene-manuilov removed their assignment Apr 12, 2023
@techanvil
Copy link
Collaborator Author

IB ✅

@eclarke1 eclarke1 added P2 Low priority and removed P1 Medium priority labels Apr 19, 2023
@mxbclang mxbclang added P1 Medium priority and removed P1 Medium priority labels Apr 26, 2023
@eugene-manuilov eugene-manuilov self-assigned this Aug 14, 2023
@eugene-manuilov
Copy link
Collaborator

Looks like those methods have already been deleted in other PRs. There is nothing else to do in this ticket. Moving it to Approval.

@eugene-manuilov eugene-manuilov removed their assignment Aug 14, 2023
@aaemnnosttv
Copy link
Collaborator

Closing as nothing was needed or done here 👍

@aaemnnosttv aaemnnosttv closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2023
@aaemnnosttv aaemnnosttv added duplicate Reason for closed issues fixed and removed P2 Low priority duplicate Reason for closed issues labels Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp: SP fixed Module: Analytics Google Analytics module related issues Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants