Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.99.0 #6854

Closed
aaemnnosttv opened this issue Apr 11, 2023 · 8 comments
Closed

Release 1.99.0 #6854

aaemnnosttv opened this issue Apr 11, 2023 · 8 comments
Labels
P0 High priority Type: Task Tasks which do not involve engineering

Comments

@aaemnnosttv
Copy link
Collaborator


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Release is prepared, tested, and deployed to wordpress.org.

Implementation Brief

  • N/A

QA Brief

  • N/A

Changelog entry

  • N/A
@aaemnnosttv aaemnnosttv added Type: Task Tasks which do not involve engineering P0 High priority labels Apr 11, 2023
@aaemnnosttv aaemnnosttv self-assigned this Apr 11, 2023
@wpdarren wpdarren self-assigned this Apr 20, 2023
@mohitwp mohitwp self-assigned this Apr 20, 2023
@nfmohit nfmohit self-assigned this Apr 21, 2023
@wpdarren
Copy link
Collaborator

wpdarren commented Apr 21, 2023

QA Update: ✅

  • I went through our release checklist.
  • Checked the Analytics module. While GA4 Reporting is behind a feature flag, I want to make sure everything works as expected.
  • Completed testing with GA4 Reporting and GTE Support feature flags disabled as we'll be testing before launch.

@wpdarren wpdarren removed their assignment Apr 21, 2023
@mohitwp
Copy link
Collaborator

mohitwp commented Apr 21, 2023

QA Update ✅

  • Tested QA checklist.
  • Tested both gathering and zero data state.
  • Verified functionality without enabling 'ga4reporting' and 'GTESupport' feature flag.
  • Tested Ga4Activation banner functionality.

@mohitwp mohitwp removed their assignment Apr 21, 2023
@jimmymadon jimmymadon self-assigned this Apr 21, 2023
@techanvil
Copy link
Collaborator

techanvil commented Apr 21, 2023

QA ✅

  • Smoke tested.
  • Verified the changes I’ve been involved with*
  • Performed some ad-hoc testing.

⚠️ I did spot a bug while testing, however this is not a regression and so it should not impact this release. The bug is that the Entity Ownership Changed notice is being displayed even when there are no shared roles for the module (this makes the notice text a bit misleading as it states "you're granting other users view-only access"). I've created a new issue for it: #6952

* I also noticed the AC for #6838 are not fully met, as the Gathering Data notice is not displayed on the view-only dashboard while GA4 is gathering data. However, this has been raised separately in #6944 and a comment on that issue indicates it should be fixed in #6897.

@tofumatt tofumatt self-assigned this Apr 21, 2023
@tofumatt
Copy link
Collaborator

QA ✅

  • Tested issues in the release
  • Smoke tested features, mostly Analytics + Tag Manager
  • Tested an existing and previous site with GTE support enabled and disabled
  • Didn't do any testing with the GA4 Reporting flag enabled as we all did lots of testing just a few days ago with it on 🙂

All looks good to me 👍🏻

@tofumatt tofumatt removed their assignment Apr 21, 2023
@nfmohit
Copy link
Collaborator

nfmohit commented Apr 23, 2023

Release Tested ✅

  • Release tested 1.99.0 thoroughly.
  • Set everything up from scratch on a live (InstaWP) site.
  • Didn't spot any unexpected console errors.
  • Verified UI in different device breakpoints.
  • Verified changes I've been involved with.
  • Used our release testing checklist to ensure everything is checked.
  • Tested with the gteSupport feature flag on and off.
  • Didn't test with the ga4Reporting feature flag as we'll we just tested it with E2E testing and bug bash.

@nfmohit nfmohit removed their assignment Apr 23, 2023
@kuasha420 kuasha420 self-assigned this Apr 23, 2023
@jimmymadon
Copy link
Collaborator

jimmymadon commented Apr 24, 2023

QA ✅

  • Smoke tested with GTE feature flag on and tested the features I was involved with. LGTM.

@jimmymadon jimmymadon removed their assignment Apr 24, 2023
@hussain-t hussain-t self-assigned this Apr 24, 2023
@kuasha420
Copy link
Contributor

QA: ✔️

  • Went through the release QA testing, set everything up from scratch on a fresh site.
  • Tested with and without gteSupport feature flag.
  • Tested the changes I was involved with.
  • Tested on a site with real data.

LGTM. 👍

@kuasha420 kuasha420 removed their assignment Apr 24, 2023
@hussain-t
Copy link
Collaborator

QA Verified ✅

  • Smoke tested.
  • Verified the changes I’ve been involved with.
  • Performed some ad-hoc testing.

@hussain-t hussain-t removed their assignment Apr 24, 2023
@aaemnnosttv aaemnnosttv removed their assignment Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Type: Task Tasks which do not involve engineering
Projects
None yet
Development

No branches or pull requests

9 participants