Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the Ad blocking recovery main notification component #6929

Closed
kuasha420 opened this issue Apr 19, 2023 · 7 comments
Closed

Create the Ad blocking recovery main notification component #6929

kuasha420 opened this issue Apr 19, 2023 · 7 comments
Labels
Exp: SP Module: AdSense Google AdSense module related issues P0 High priority Type: Feature New feature

Comments

@kuasha420
Copy link
Contributor

kuasha420 commented Apr 19, 2023

Feature Description

A new component that displays the main notification of Ad Blocker Detection should be created according to the Figma design. This component will later be rendered when appropriate using the Widgets API in the Monetization section of Site Kit's main dashboard.

Screenshot_20230421_173752


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • A new component that displays the main notification of Ad Blocking Recovery should be created based on the Figma design.
  • The layout, graphics, typography and CTA buttons should match the design.
  • Clicking on the primary CTA should navigate user to the googlesitekit-ad-blocking-recovery page.
  • Clicking on secondary CTA should permanently dismiss it.
  • Note that this issue is only about creating the component, it will be placed on the dashboard in Display Ad Blocking Recovery Notification in the dashboard when all the conditions are met #6953

Implementation Brief

  • Create AdBlockingRecoveryNotification component in assets/js/modules/adsense/components/dashboard.
    • Create the layout defined in the design using the Grid, Row. and Column layout components.
    • Save the graphics from Figma in assets/svg folder and use it.
    • Use SpinnerButton for the primary CTA.
      • Use navigateTo selector from CORE_LOCATION to navigate user to the defined page in the AC.
    • Use a regular text Button for the secondary CTA.
      • Use dismissed-items to permanently dismiss the notification component when pressed.
    • Create assets/sass/components/dashboard/googlesitekit-ad-blocking-recovery-notification.scss and add any component style here based on Figma.
      • Styles include but not limited to: margin, padding, typography etc.
      • Include it in the assets/sass/admin.scss
  • Since there is no design available for mobile view, follow the prior arts on Success Notification and elsewhere. Namely,
    • Hide the graphics.
    • Put the disclaimer text under the CTA buttons.
  • Add story for the component.

Test Coverage

  • Not needed.

QA Brief

  • Set up the site and enable the adBlockerDetection feature flag.
  • Activate the adsense module.
  • Go to the dashboard and scroll down to the monetization section.
  • Ensure that you see the widget with the Ad Blocker Recovery notification.
  • Click on the Set up now button and verify that you get redirected to the new ad blocker recovery page.
  • Go back to the dashboard and find the widget again.
  • Now click on the Maybe later link and ensure that the widget is dismissed now.

Changelog entry

  • Add Ad Blocking Recovery set up CTA to the Monetization section of the dashboard.
@kuasha420 kuasha420 self-assigned this Apr 19, 2023
@kuasha420 kuasha420 added Type: Feature New feature P0 High priority Module: AdSense Google AdSense module related issues labels Apr 19, 2023
@kuasha420 kuasha420 removed their assignment Apr 21, 2023
@tofumatt tofumatt self-assigned this Apr 24, 2023
@tofumatt
Copy link
Collaborator

ACs here are good 👍🏻

@tofumatt tofumatt removed their assignment Apr 24, 2023
@kuasha420 kuasha420 self-assigned this Apr 24, 2023
@kuasha420 kuasha420 removed their assignment May 9, 2023
@eugene-manuilov eugene-manuilov self-assigned this May 10, 2023
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov
Copy link
Collaborator

@marrrmarrr @aaemnnosttv the banner contains the Learn More link in the description. Which URL should we use for that link?

@kuasha420
Copy link
Contributor Author

@eugene-manuilov It should point https://support.google.com/adsense/answer/11576589 with correct locale as seen in Figma. Cheers.

@wpdarren
Copy link
Collaborator

wpdarren commented May 29, 2023

QA Update: ⚠️

@eugene-manuilov I have noticed a few differences between the figma designs and test site.

  1. Space between the asterix and text.
Screenshots

image
image

  1. Font colour difference.
Screenshot

image

Figma says it should be #6C726E admittedly, the colour on the plugin is easier to read, but thought I'd flag it.

  1. In the IB it mentions:

Use SpinnerButton for the primary CTA

I didn't see any spinning animation on the button when I clicked it.

adb.mp4
  1. I know it doesn't mention dimensions should be the same as figma in the AC, but I noticed a few differences.

The height of the notification component.

Screenshot

image

The width/height of the SVG.

Screenshot

image

Interested in your thoughts.

@eugene-manuilov
Copy link
Collaborator

Thanks, @wpdarren. I have created a new PR that adjusts issues 1, 2 and partially 5. The 4th is not an issue because the spinner button isn't really needed there because that button is just a link. Once my PR is reviewed, I'll assign this ticket back to you.

@tofumatt tofumatt assigned wpdarren and unassigned tofumatt May 31, 2023
@wpdarren
Copy link
Collaborator

wpdarren commented Jun 1, 2023

QA Update: ✅

Verified:

  • With the adBlockerDetection feature flag enabled and AdSense setup.
    • The widget with the Ad Blocker Recovery notification appears.
    • When clicking on the Set up now button and you are redirected to the new ad blocker recovery page.
    • When clicking on the Maybe later link the widget is dismissed.

The issues reported above are all fixed.

image

@wpdarren wpdarren removed their assignment Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp: SP Module: AdSense Google AdSense module related issues P0 High priority Type: Feature New feature
Projects
None yet
Development

No branches or pull requests

5 participants