-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the Ad blocking recovery main notification component #6929
Comments
ACs here are good 👍🏻 |
IB ✔️ |
@marrrmarrr @aaemnnosttv the banner contains the |
@eugene-manuilov It should point |
QA Update:
|
Thanks, @wpdarren. I have created a new PR that adjusts issues 1, 2 and partially 5. The 4th is not an issue because the spinner button isn't really needed there because that button is just a link. Once my PR is reviewed, I'll assign this ticket back to you. |
QA Update: ✅Verified:
The issues reported above are all fixed. |
Feature Description
A new component that displays the main notification of Ad Blocker Detection should be created according to the Figma design. This component will later be rendered when appropriate using the Widgets API in the Monetization section of Site Kit's main dashboard.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
googlesitekit-ad-blocking-recovery
page.Implementation Brief
AdBlockingRecoveryNotification
component inassets/js/modules/adsense/components/dashboard
.Grid
,Row
. andColumn
layout components.assets/svg
folder and use it.SpinnerButton
for the primary CTA.navigateTo
selector fromCORE_LOCATION
to navigate user to the defined page in the AC.Button
for the secondary CTA.dismissed-items
to permanently dismiss the notification component when pressed.assets/sass/components/dashboard/googlesitekit-ad-blocking-recovery-notification.scss
and add any component style here based on Figma.assets/sass/admin.scss
Test Coverage
QA Brief
adBlockerDetection
feature flag.Set up now
button and verify that you get redirected to the new ad blocker recovery page.Maybe later
link and ensure that the widget is dismissed now.Changelog entry
The text was updated successfully, but these errors were encountered: