UA settings hidden from an Admin with no access

[jimmymadon]

Bug Description

With the ga4Reporting feature flag enabled, when an authenticated admin does not have access to the connected UA property, then they are not shown the UA settings in the Settings Edit Form. These should be visible but "disabled" as they currently are with the feature flag disabled.

Steps to reproduce

1. Enable the ga4Reporting feature flag.
2. Setup Site Kit and connect a UA property.
3. Now login as another Admin whose Google Account does not have access to the connected UA property.
4. Go to Analytics Settings and try editing the settings. The settings fields and toggle to enable/disable UA are completely hidden instead of being displayed but disabled.

Screenshots

Screen.Recording.2023-05-09.at.15.59.32.mov

Additional Context

While working on #7004, I realised there are a few places in the code which completely hide the "Universal Analytics" toggle and settings if there are no properties available. I believe we would still want to show the toggle and the settings but they should be disabled like the rest of the settings. We simply have to differentiate between when the properties aren't available due to no access or because there really aren't any properties available for the selected account. Some small tweaks will be required below:

site-kit-wp/assets/js/modules/analytics/components/common/AccountSelect.js

Lines 72 to 76 in b5177d3

	useEffect( () => {
	if ( isUAEnabled && properties.length === 0 ) {
	setValues( FORM_SETUP, { enableUA: false } );
	}
	}, [ isUAEnabled, properties, setValues ] );

site-kit-wp/assets/js/modules/analytics/components/settings/SettingsForm.js

Lines 142 to 154 in b5177d3

	{ ga4ReportingEnabled && properties.length > 0 && (
	<div className="googlesitekit-settings-module__fields-group">
	<h4 className="googlesitekit-settings-module__fields-group-title">
	{ __( 'Universal Analytics', 'google-site-kit' ) }
	</h4>
	<EnableUniversalAnalytics
	hasModuleAccess={ hasAnalyticsAccess }
	showErrors
	>
	<SettingsUseSnippetSwitch />
	</EnableUniversalAnalytics>
	</div>
	) }

site-kit-wp/assets/js/modules/analytics/components/common/EnableUniversalAnalytics.js

Lines 115 to 117 in b5177d3

	if ( properties.length === 0 ) {
	return null;
	}

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• With the ga4Reporting feature flag enabled, the functionality introduced for Analytics settings in Restrict editing module entity settings to users who have access #4825 should work as before.
  • An authenticated admin who does not have access to the connected Universal Analytics property should be able to view the UA settings fields when editing Analytics settings. As per Restrict editing module entity settings to users who have access #4825, these fields should only contain the 'raw' settings values such as Property ID instead of the 'rich' values like Property ID + Property Name.

Implementation Brief

• As the "Additional context" above mentioned, differentiating between when properties are unavailable due to no access and when they really aren't available solves this issue. This has been tried and tested in a new simple PR - Show disabled UA settings to admin with no property access. #7041 which can be reviewed and merged.
• The failing VRT scenario needs to be fixed - "Universal Analytics" title should be moved into the EnableUniversalAnalytics component so that it is only rendered when the settings should be rendered.

Test Coverage

• No new tests required.

QA Brief

• Follow the steps to reproduce and verify the UA settings with disabled raw values are shown as per the AC.
• Follow the steps to reproduce while logging in as an admin with access to the UA property to ensure they can still see, edit and save UA/GA4 settings.
• Follow the steps to reproduce with the feature flag disabled and ensure the "old" UA/GA4 Edit Settings form works as before.
• Test UA and GA4 setup from scratch with and without the ga4Reporting feature flag.

Changelog entry

• Update Universal Analytics settings UX for consistency with previous interface when GA4 is the primary version and current admin lacks access.

[tofumatt]

IB ✅

[mohitwp]

QA Update ✅

• Tested on dev environment.
• Verified an authenticated admin who does not have access to the connected Universal Analytics property is now able to view the UA settings fields when editing Analytics settings.
• Tested when 'ga4Reporting' Feature flag is enabled and Dashboard view is UA.
• Tested when 'ga4Reporting' Feature flag is enabled and Dashboard view is Ga4.
• Verified analytics setup when 'ga4Reporting' feature flag is enabled.
• Verified analytics setup when 'ga4Reporting' feature flag is not enabled.

ga4Reporting enabled - only ga4 connected

ga4 reporting enabled - UA connected and view is ga4

ga4 reporting enabled - UA connected and view is UA