-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GA tracking for RRM #8847
Comments
This is blocked by this internal task to define GA tracking parameters for Reader Revenue Management. |
Thank you for the IB, @ankitrox . Please take a look at my comments below:
To track the view notification for the overlay notification, we should use the Also, do you think we should increase the estimate by a notch as these are a lot of components and involves quite extensive test coverage, just to be on the safe side? |
Thank you @nfmohit . I've updated the point to pass Also, I've bumped the estimate to |
Thank you @ankitrox! IB ✅ |
Feature Description
GA event tracking should be added to different parts of the RRM module, such as the user-facing banner notification (#8846), publication-approved overlay notification (#8843), publication onboarding state notice (#8838), and module success banner (#8840).
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
The following GA events should be tracked for the given actions in different Reader Revenue Manager module elements. See the GA events sheet.
Implementation Brief
viewContext
useuseViewContext
hook.trackEvent
method should be used to track the event in GA.assets/js/modules/reader-revenue-manager/components/ReaderRevenueManagerSetupCTABanner.js
component added in Implement RRM setup CTA widget #8846, do the following.useEffect
hook in the component to track theview_notification
event with category name{viewContext}_rrm-setup-notification
.onSetupCallback
to track the eventconfirm_notification
with{viewContext}_rrm-setup-notification
onDismiss
callback to track the eventdismiss_notification
with{viewContext}_rrm-setup-notification
assets/js/modules/reader-revenue-manager/components/common/PublicationOnboardingStateNotice.js
component added in Implement<PublicationOnboardingStateNotice>
component #8838, do the following.onboardingState
is present inactionableOnboardingStates
array. Pass the label as value ofonboardingState
.useEffect
hook in the component to track theview_notification
event with category name{viewContext}_rrm-setup-notification
.onClick
prop inLink
to track theconfirm_notification
event with category name{viewContext}_rrm-onboarding-state-notification
.assets/js/modules/reader-revenue-manager/components/dashboard/PublicationApprovedOverlayNotification.js
component added in Implement<PublicationApprovedOverlayNotification>
component #8843, do the following.onShow
prop toOverlayNotification
component which should track theview_notification
event with category name{viewContext}_rrm-publication-approved-notification
.dismissNotification
function, to track the eventdismiss_notification
with category name{viewContext}_rrm-publication-approved-notification
.Enable features
CTAButton
component, addonClick
prop to track eventconfirm_notification
with category{viewContext}_rrm-publication-approved-notification
.assets/js/modules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.js
component added in Implement RRM module setup success banner #8840, do the following.onboardingState
is one ofPENDING_VERIFICATION
,ONBOARDING_ACTION_REQUIRED
, orONBOARDING_COMPLETE
.useEffect
hook in the component to track theview_notification
event with category name{viewContext}_rrm-setup-success-notification
. Add the dependencies correctly for the hook.onClick
handler as prop which should track event on dismiss and on click. The prop should be passed toSubtleNotification
component.Test Coverage
QA Brief
RRM setup CTA notification
Onboarding state notification.
Site Kit > Settings > Reader Revenue Manager
, expand panel.Onboarding success notification
Approved publication notice
Changelog entry
The text was updated successfully, but these errors were encountered: