Refactor the ZeroDataNotification to use the new Notifications datastore

[jimmymadon]

Feature Description

This issue will "use" the new datastore infrastructure to queue the ZeroDataNotification using the new datastore infrastructure.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The ZeroDataNotification should be refactored and rendered (queued) using the new core/notifications datastore. This means that the component should not be called directly but via the generic getQueuedNotifications selector.
• The refactored component should be its own standalone component without any business logic that prevents it from rendering. This component should be passed through when registering the new notification.

Implementation Brief

• Wait for the dependency issues to be merged.
• In assets/js/googlesitekit/notifications/register-defaults.js:
  • Add the registration of the ZeroDataNotification notification similar to the GatheringDataNotification component.
  • Priority should be 10 more than the GatheringDataNotification.
  • The check requirements call back function should be similar to GatheringDataNotification. However, return false if either hasSearchConsoleGatheringData or hasAnalyticsGatheringData params are true. This is so that, either the GatheringDataNotification and the ZeroDataNnotification NEVER get queued together.
  • Within BannerNotifications and EntityBannerNotifications, remove the call to ZeroDataNotification.

Test Coverage

• No new tests required.

QA Brief

Ideally - WAIT for this issue to be merged and then QA both #8976 and this issue together as they are exactly the same pattern in code.

• Thoroughly smoke test the GatheringData and ZeroData notifications:
  • Test when only Search Console is gathering data (and analytics is disconnected).
  • Test when both, Search Console and Analytics is Gathering Data.
  • Test when Search Console has finished gathering data but Analytics is still Gathering Data.
  • Test when either and both, SC and Analytics are in Zero data state.
  • Test all of the above for the Entity Dashboard as well.
• Test when any other notification, say any other SetupSuccessBannerNotification is active - they should take precedence over the Gathering and Zero Data notifications.
• Smoke test the remaining notifications to ensure they still work normally.
• Test the new Storybook stories in Components -> Notifications.

Changelog entry

• Refactor the ZeroDataNotification to use the new Notifications approach.

[eugene-manuilov]

AC and IB ✔️

[jimmymadon]

@mohitwp This issue is now merged, so I have assigned you this one as you were assigned to #8976. Both these issues can be QAed now together as per their QAB. c.c. @wpdarren

[mohitwp]

QA Update ❌

• Tested on dev environment.
• Verified zero data notifications on main, entity and view only dashboard.
• Smoke tested plugin notification and verified that other notifiations - take precedence over the Gathering and Zero Data notifications.
• Tested storybook component >notifications stories.

@jimmymadon
Issue > On View only dashboard zero and gathering data notifications are not showing. On latest environment zero and gathering data state notifications are showing.

Recording.1304.mp4

Question > The "AdSense - Earnings at risk" notice reappears when we open the dashboard in a new tab, even after clicking "OK, Got It!" This occurs in both the latest and development environments. Is this expected?

Recording.1305.mp4

PASS CASES

SC gathering Data

SC and Analytics gathering data

Entity Dashboard (SC and Analytics gathering data)

SC is in gathering data state and Analytics is in zero data state.

Entity Dashboard ( SC is in gathering data state and Analytics is in zero data state.)

Both SC and analytics are in zero data state

Entity Dashboard ( Both SC and analytics are in zero data state)

Only Analytics is in gathering data state

Entity dashboard (Only Analytics is in gathering data state)

Other notifications- Another Admin

[jimmymadon]

Holding this issue in CR with me until #8976 has its follow up PR merged as it fixes this issue too. Then will move this straight to QA.

[jimmymadon]

@mohitwp Thanks - back to you for another pass!

[mohitwp]

QA Update ✅

• Tested on dev environment.
• Verified zero data notifications and gathering data notifications on main, entity and view only dashboard.
• Smoke tested plugin notification and verified that other notifications - take precedence over the Gathering and Zero Data notifications.
• Tested storybook component >notifications stories.
• Verified that view only dashboard related issue is resolve now. Zero and gathering data notifications are now showing on View only dashboard.
• Note - There are a few additional issues, but these are due to changes introduced in Refactor the ZeroDataNotification to use the new lighter Notification component. #9184 and Refactor the GatheringDataNotification to use a newly refactored version of the BannerNotification component. #9071. They will be addressed in a follow-up pull request

Recording.1324.mp4

Recording.1325.mp4