Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include 'Learn more' link on RRM set up screen #9259

Closed
1 task
wpdarren opened this issue Aug 30, 2024 · 7 comments
Closed
1 task

Include 'Learn more' link on RRM set up screen #9259

wpdarren opened this issue Aug 30, 2024 · 7 comments
Labels
Module: RRM Reader Revenue Manager module related issues P1 Medium priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature

Comments

@wpdarren
Copy link
Collaborator

wpdarren commented Aug 30, 2024

Feature Description

On the Reader Revenue Manager setup screens it would be nice to include a Learn more link so the user can find out more about the feature before setting it up.

Image

Asana ticket can be found here


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

  • Update assets/js/modules/reader-revenue-manager/components/common/PublicationCreate.js, use createInterpolateElement to add a Learn More link, linking to the support article in the AC.

Test Coverage

  • No additional tests required. Check no new failures occur.

QA Brief

  1. Enable RRM feature in tester plugin.
  2. Setup the feature and make sure that you don't have any publications setup already.
  3. In the setup screen, you must see the Learn More link pointing to https://support.google.com/news/publisher-center/answer/11449914

Changelog entry

  • Include a "Learn more" link on the Reader Revenue Manager setup screen shown when the user doesn't have an existing publication.
@wpdarren wpdarren added P1 Medium priority Type: Enhancement Improvement of an existing feature Module: RRM Reader Revenue Manager module related issues labels Aug 30, 2024
@techanvil techanvil self-assigned this Sep 2, 2024
@techanvil
Copy link
Collaborator

techanvil commented Sep 2, 2024

I've raised a question about this issue on its Asana task, and will hold off adding AC while we consider it further.

@ivonac4 ivonac4 added the Team M Issues for Squad 2 label Sep 4, 2024
@techanvil
Copy link
Collaborator

Hi @wpdarren @aaemnnosttv, I'm assigning this to you for visibility, please can you take a look at the linked Asana task when you have a moment?

@techanvil techanvil assigned wpdarren and aaemnnosttv and unassigned techanvil Sep 10, 2024
@aaemnnosttv
Copy link
Collaborator

@techanvil I've replied on that, thanks for raising it.

@aaemnnosttv aaemnnosttv assigned techanvil and unassigned aaemnnosttv and wpdarren Oct 1, 2024
@techanvil
Copy link
Collaborator

Thanks @aaemnnosttv! I've added AC for this issue, including a more contextually relevant link as per your suggestion on Asana.

@techanvil techanvil removed their assignment Oct 24, 2024
@nfmohit
Copy link
Collaborator

nfmohit commented Oct 24, 2024

AC ✅

@benbowler benbowler self-assigned this Oct 31, 2024
@ivonac4 ivonac4 added the Next Up Issues to prioritize for definition label Oct 31, 2024
@benbowler benbowler removed their assignment Oct 31, 2024
@techanvil techanvil self-assigned this Oct 31, 2024
@techanvil
Copy link
Collaborator

IB ✅

@techanvil techanvil removed their assignment Oct 31, 2024
@ankitrox ankitrox self-assigned this Nov 5, 2024
@ankitrox ankitrox removed their assignment Nov 5, 2024
@ivonac4 ivonac4 removed the Next Up Issues to prioritize for definition label Nov 5, 2024
@techanvil techanvil assigned techanvil and ankitrox and unassigned techanvil Nov 5, 2024
@ankitrox ankitrox assigned techanvil and unassigned ankitrox Nov 6, 2024
@techanvil techanvil removed their assignment Nov 6, 2024
@kelvinballoo kelvinballoo self-assigned this Nov 6, 2024
@kelvinballoo
Copy link
Collaborator

QA Update ✅

This was verified good. Moving ticket to approval.

  • The RRM setup screen with the Create publication CTA includes a "Learn more" link.
    The "Learn more" link is appended to the second descriptive line of the copy:
    Once you have created your publication, it is submitted for review. Learn more

    Image

  • 'Learn more' links to the "Get started with Reader Revenue Manager" support article:
    https://support.google.com/news/publisher-center/answer/11449914

    Image

  • On accounts with existing publications, there was no 'Learn More' CTA.

    Image

@kelvinballoo kelvinballoo removed their assignment Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: RRM Reader Revenue Manager module related issues P1 Medium priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

9 participants