Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup flow instruction to set up RRM in Publisher Center #9308

Closed
4 tasks done
nfmohit opened this issue Sep 5, 2024 · 2 comments
Closed
4 tasks done

Add setup flow instruction to set up RRM in Publisher Center #9308

nfmohit opened this issue Sep 5, 2024 · 2 comments
Labels
Module: RRM Reader Revenue Manager module related issues P0 High priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature

Comments

@nfmohit
Copy link
Collaborator

nfmohit commented Sep 5, 2024

Feature Description

The Reader Revenue Manager module setup flow should include instruction to set up the service in Google Publisher Center.

Reported in bug bash here.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The initial part of the descriptive text on the "no publications" variant of the RRM setup screen should be updated.
    • Existing copy: "To complete your Reader Revenue Manager account setup you will need to create a publication."
    • New copy: "To complete your Reader Revenue Manager account setup you will need to create a publication and set up Reader Revenue Manager in Publisher Center."

Implementation Brief

  • In assets/js/modules/reader-revenue-manager/components/common/PublicationCreate.js:
    • Update the sentence specified in the ACs accordingly.

Test Coverage

  • Fix any failing tests due to the change in copy.
  • Update any failing VRTs due to the change in copy.

QA Brief

  1. RRM module is disabled, but the feature is enabled in tester plugin.

  2. Add any random URL https://somedomain.com in Custom Site URL in tester settings.

  3. Enable the RRM module from Site Kit settings.

  4. It will redirect to the setup screen. Instructions on the screen must match with that of AC.

Changelog entry

  • Improve instructions for creating a new publication in the Reader Revenue Manager module setup screen.
@nfmohit nfmohit self-assigned this Sep 5, 2024
@nfmohit nfmohit added P0 High priority Type: Enhancement Improvement of an existing feature Team M Issues for Squad 2 Module: RRM Reader Revenue Manager module related issues labels Sep 5, 2024
@nfmohit nfmohit removed their assignment Sep 5, 2024
@kuasha420 kuasha420 self-assigned this Sep 8, 2024
@kuasha420
Copy link
Contributor

IB ✔️

@kuasha420 kuasha420 removed their assignment Sep 8, 2024
@ankitrox ankitrox assigned ankitrox and unassigned ankitrox Sep 10, 2024
@nfmohit nfmohit assigned nfmohit and unassigned nfmohit Sep 11, 2024
@wpdarren wpdarren self-assigned this Sep 12, 2024
@wpdarren
Copy link
Collaborator

QA Update: ✅

Verified:

The initial part of the descriptive text on the "no publications" variant of the RRM setup screen now reads as the new copy: To complete your Reader Revenue Manager account setup you will need to create a publication and set up Reader Revenue Manager in Publisher Center.

image

@wpdarren wpdarren removed their assignment Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: RRM Reader Revenue Manager module related issues P0 High priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants