Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RRM setup banner image doesn't appear on some breakpoints #9329

Closed
1 task
kelvinballoo opened this issue Sep 11, 2024 · 2 comments
Closed
1 task

RRM setup banner image doesn't appear on some breakpoints #9329

kelvinballoo opened this issue Sep 11, 2024 · 2 comments
Labels
Module: RRM Reader Revenue Manager module related issues Next Up Issues to prioritize for definition P1 Medium priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature

Comments

@kelvinballoo
Copy link
Collaborator

kelvinballoo commented Sep 11, 2024

Bug Description

While testing RRM, I noticed that on Desktop Safari, there are some breakpoints that will not show the image at all.

  • Refer to the video below for the desktop safari

    Safari.image.disappears.mov
  • I went on to test this on smaller breakpoint on an iPhone 15 Pro max (real) on Safari and Chrome browser. I could not see the graphic

    Safari

    IMG_9792

    Chrome
    IMG_9793

Steps to reproduce

  1. Enable RRM feature flag
  2. Go to SK dashboard on Desktop Safari (or any of the devices mentioned in the description)to spot the RRM setup banner and resize the window to a smaller breakpoint until the image disappears.

Screenshots

Additional Context

  • PHP Version:
  • OS: [e.g. iOS]
  • Browser: [e.g. chrome, safari]
  • Plugin Version: [e.g. 22]
  • Device: [e.g. iPhone6]

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When viewing the RRM Setup CTA Banner at narrow breakpoints on the devices/browsers listed above, the banner should be displayed with its graphic below the buttons, as seen for example here in Chrome:

Image

Implementation Brief

Test Coverage

  • No new tests needed.

QA Brief

  • Follow the steps to reproduce and verify the graphic does appear below the buttons as expected.

Changelog entry

  • Fix a bug that prevented the appearance of the Reader Revenue Manager setup banner graphic.
@ivonac4 ivonac4 added Team M Issues for Squad 2 P1 Medium priority Module: RRM Reader Revenue Manager module related issues Type: Enhancement Improvement of an existing feature labels Sep 12, 2024
@ivonac4 ivonac4 added the Next Up Issues to prioritize for definition label Oct 31, 2024
@techanvil techanvil assigned techanvil and unassigned techanvil Nov 4, 2024
@nfmohit nfmohit self-assigned this Nov 6, 2024
@nfmohit
Copy link
Collaborator

nfmohit commented Nov 7, 2024

IB ✅

@nfmohit nfmohit removed their assignment Nov 7, 2024
@techanvil techanvil self-assigned this Nov 8, 2024
@techanvil techanvil removed their assignment Nov 8, 2024
@nfmohit nfmohit assigned nfmohit and unassigned nfmohit Nov 8, 2024
@kelvinballoo kelvinballoo self-assigned this Nov 11, 2024
@kelvinballoo
Copy link
Collaborator Author

QA Update ✅

  • Verified on Desktop Safari (on MacOS Sonoma) across a few breakpoints and the image is appearing accordingly.

    Image

    Image

  • Verified on iPhone 15 Pro Max (Safari) and the graphic is showing as expected.

    Image

  • Verified on other browsers to ensure no regression : Chrome, Firefox, Edge. All are showing the graphic as expected.

    Edge:

    Image

    Firefox:

    Image

    Chrome:

    Image

Moving ticket to approval.

@kelvinballoo kelvinballoo removed their assignment Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: RRM Reader Revenue Manager module related issues Next Up Issues to prioritize for definition P1 Medium priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants