-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaffold Sign in With Google Module #9332
Comments
IB ✔️ |
QA Update ❌
Issue 1 > CTA link graphic symbol is getting little cut from bottom. Issue 2 > 'New' badge background color is different in Figma. |
@mohitwp that problem is out of scope for this ticket. If you think we should fix it, then please create a new issue for it.
Updated and created a new PR for it. Once approved and merged, it will be fixed. |
QA Update ✅
Note : I will create a separate ticket for the issue 1 reported above. |
Feature Description
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
signInWithGoogleModule
feature flag is enabled. (Similar to how therrmModule
behaves, see:site-kit-wp/includes/Core/Modules/Modules.php
Lines 181 to 183 in cd076ee
Implementation Brief
includes/Modules/Sign_In_With_Google.php
Module_With_Assets, Module_With_Deactivation, Module_With_Settings
. See existing modules like PageSpeed or RRM for examples.Test Coverage
tests/phpunit/integration/Modules/Sign_In_With_GoogleTest.php
)signInWithGoogleModule
feature flag is enabledQA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: