Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold Sign in With Google Module #9332

Closed
3 tasks done
tofumatt opened this issue Sep 11, 2024 · 4 comments
Closed
3 tasks done

Scaffold Sign in With Google Module #9332

tofumatt opened this issue Sep 11, 2024 · 4 comments
Labels
Module: Sign in with Google Sign in with Google (SiwG) related issues. P1 Medium priority Team S Issues for Squad 1

Comments

@tofumatt
Copy link
Collaborator

tofumatt commented Sep 11, 2024

Feature Description


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • A module for Sign in With Google should be created with support for settings.
  • The module should only appear/function when the signInWithGoogleModule feature flag is enabled. (Similar to how the rrmModule behaves, see:
    if ( Feature_Flags::enabled( 'rrmModule' ) ) {
    $this->core_modules[ Reader_Revenue_Manager::MODULE_SLUG ] = Reader_Revenue_Manager::class;
    }
    )
  • The module should use the Google logo as its icon, see Figma: https://www.figma.com/design/h9yGR15Pg2DUtgERW4AFAv/Sign-in-with-Google?node-id=27-1075&t=IxHiqEfnlAaEGQ1D-4
  • The module should be named "Sign in with Google"
  • The module should have a "Beta" and "New" badge next to it in the modules list
  • The module should have a description that reads "Improve user engagement, trust, and data privacy, while creating a simple, secure, and personalised experience for your visitors"

Implementation Brief

  • Add a new file for the Sign in with Google module includes/Modules/Sign_In_With_Google.php
  • Scaffold the module with the minimal number of functions to satisfy Module_With_Assets, Module_With_Deactivation, Module_With_Settings. See existing modules like PageSpeed or RRM for examples.
  • Add the Google icon as its module icon, and the title/description from the ACs

Test Coverage

  • Add basic tests to ensure module is scaffolded/loaded properly (tests/phpunit/integration/Modules/Sign_In_With_GoogleTest.php)
  • Add tests to ensure the module is only available when the signInWithGoogleModule feature flag is enabled

QA Brief

  • Enable the signInWithGoogle feature flag
  • Go to the settings page and open the "connect more services" tab
  • Ensure that you see the new module in the list of available modules and it matches the requirements in AC.

Changelog entry

  • Add Sign in with Google module.
@tofumatt tofumatt added the P0 High priority label Sep 11, 2024
@tofumatt tofumatt self-assigned this Sep 11, 2024
@tofumatt tofumatt added the Module: Sign in with Google Sign in with Google (SiwG) related issues. label Sep 11, 2024
@binnieshah binnieshah added Next Up Issues to prioritize for definition Team S Issues for Squad 1 labels Sep 17, 2024
@tofumatt tofumatt removed their assignment Sep 22, 2024
@eugene-manuilov eugene-manuilov self-assigned this Sep 23, 2024
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@binnieshah binnieshah added P1 Medium priority and removed P0 High priority Next Up Issues to prioritize for definition labels Sep 23, 2024
@eugene-manuilov eugene-manuilov removed their assignment Sep 24, 2024
@zutigrm zutigrm assigned zutigrm and eugene-manuilov and unassigned zutigrm Sep 25, 2024
@zutigrm zutigrm removed their assignment Sep 25, 2024
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Sep 25, 2024
@mohitwp mohitwp self-assigned this Sep 27, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Sep 27, 2024

QA Update ❌

  • Tested on dev environment.
  • Verified the module appear/function only when the signInWithGoogleModule feature flag is enabled.
  • Verified that the module uses the Google logo as its icon.
  • Verified that the module named "Sign in with Google"
  • Verified that the module have a "Beta" and "New" badge next to it in the modules list
  • Verified that the module have a description that reads "Improve user engagement, trust, and data privacy, while creating a simple, secure, and personalised experience for your visitors".

@eugene-manuilov

Issue 1 > CTA link graphic symbol is getting little cut from bottom.

image

image

Issue 2 > 'New' badge background color is different in Figma.

image

Figma

image

@eugene-manuilov
Copy link
Collaborator

Issue 1 > CTA link graphic symbol is getting little cut from bottom.

@mohitwp that problem is out of scope for this ticket. If you think we should fix it, then please create a new issue for it.

Issue 2 > 'New' badge background color is different in Figma.

Updated and created a new PR for it. Once approved and merged, it will be fixed.

@eugene-manuilov eugene-manuilov removed their assignment Oct 1, 2024
@tofumatt tofumatt removed their assignment Oct 2, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Oct 2, 2024

QA Update ✅

  • Tested on main environment.
  • Verified that beta label background color is now updated and it is same as Figma.
  • Verified the module appear/function only when the signInWithGoogleModule feature flag is enabled.
  • Verified that the module uses the Google logo as its icon.
  • Verified that the module named "Sign in with Google"
  • Verified that the module have a "Beta" and "New" badge next to it in the modules list
  • Verified that the module have a description that reads "Improve user engagement, trust, and data privacy, while creating a simple, secure, and personalised experience for your visitors".

Note : I will create a separate ticket for the issue 1 reported above.

image

image

@mohitwp mohitwp removed their assignment Oct 2, 2024
@tofumatt tofumatt closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Sign in with Google Sign in with Google (SiwG) related issues. P1 Medium priority Team S Issues for Squad 1
Projects
None yet
Development

No branches or pull requests

5 participants