-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ads PAX Beta - Update Ads Setup Text on Connect More Services Screen #9425
Labels
javascript
Pull requests that update Javascript code
Module: Ads
Google Ads module related issues
P0
High priority
Team S
Issues for Squad 1
Type: Enhancement
Improvement of an existing feature
Comments
10upsimon
added
javascript
Pull requests that update Javascript code
Module: Ads
Google Ads module related issues
Team S
Issues for Squad 1
Type: Enhancement
Improvement of an existing feature
P0
High priority
labels
Sep 27, 2024
6 tasks
AC ✅ |
@10upsimon Perhaps it will be more straightforward to change it directly in the backend when feature flag is enabled, in |
@zutigrm ya, good shout, let me update. |
Thanks @10upsimon IB ✅ |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javascript
Pull requests that update Javascript code
Module: Ads
Google Ads module related issues
P0
High priority
Team S
Issues for Squad 1
Type: Enhancement
Improvement of an existing feature
Feature Description
For users enrolled in the Beta phase of the Ads PAX integration (those using the mini plugin), the Ads module setup text appearing on the "Connect More Services" screen is required to be updated to be more reflective of a scenario where users do not have an existing Ads account.
The new setup text should read as follows:
Grow sales, leads or awareness for your business by advertising with Google Ads
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Google Site Kit > Settings
should be amended to read as follows: "Grow sales, leads or awareness for your business by advertising with Google Ads"adsPAX
feature flag is detected.Implementation Brief
includes/Modules/Ads.php
setup_info()
method:description
array key based on whether the result ofFeature_Flags::enabled( 'adsPax' )
istrue
or not.Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: