Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads PAX Beta - Update Ads Setup Text on Connect More Services Screen #9425

Closed
3 tasks done
10upsimon opened this issue Sep 27, 2024 · 5 comments
Closed
3 tasks done
Labels
javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@10upsimon
Copy link
Collaborator

10upsimon commented Sep 27, 2024

Feature Description

For users enrolled in the Beta phase of the Ads PAX integration (those using the mini plugin), the Ads module setup text appearing on the "Connect More Services" screen is required to be updated to be more reflective of a scenario where users do not have an existing Ads account.

The new setup text should read as follows:

Grow sales, leads or awareness for your business by advertising with Google Ads

Site Kit by Google Settings ‹ sitekit 10uplabs com — WordPress 2024-09-27 at 11 19 35 AM


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • For users enrolled in the Beta phase of the Ads PAX integration (those making use of the mini plugin), the text within the Ads module setup card in the "Connect More Services" tab of Google Site Kit > Settings should be amended to read as follows: "Grow sales, leads or awareness for your business by advertising with Google Ads"
    • This change of text should only be applied when the adsPAX feature flag is detected.

Implementation Brief

  • Within includes/Modules/Ads.php
    • Within the setup_info() method:
      • Conditionally alter the string value of the description array key based on whether the result of Feature_Flags::enabled( 'adsPax' ) is true or not.

Test Coverage

  • N/A

QA Brief

  • Go to Settings -> Connect More Services, check the Ads module copy:
    • With the adsPAX feature flag disabled the copy should be: "Track conversions for your existing Google Ads campaigns"
    • With the adsPAX feature flag enabled the copy should be: "Grow sales, leads or awareness for your business by advertising with Google Ads"

Changelog entry

  • Update copy text in Google Ads module when Partner Ads Experience is enabled.
@10upsimon 10upsimon added javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature P0 High priority labels Sep 27, 2024
@zutigrm zutigrm self-assigned this Sep 27, 2024
@zutigrm
Copy link
Collaborator

zutigrm commented Sep 27, 2024

AC ✅

@zutigrm zutigrm assigned zutigrm and unassigned zutigrm Sep 27, 2024
@binnieshah binnieshah added the Next Up Issues to prioritize for definition label Sep 27, 2024
@10upsimon 10upsimon assigned 10upsimon and zutigrm and unassigned 10upsimon Sep 30, 2024
@zutigrm
Copy link
Collaborator

zutigrm commented Sep 30, 2024

@10upsimon Perhaps it will be more straightforward to change it directly in the backend when feature flag is enabled, in Google\Site_Kit\Modules\Ads::setup_info?

@zutigrm zutigrm assigned 10upsimon and unassigned zutigrm Sep 30, 2024
@10upsimon
Copy link
Collaborator Author

@10upsimon Perhaps it will be more straightforward to change it directly in the backend when feature flag is enabled, in Google\Site_Kit\Modules\Ads::setup_info?

@zutigrm ya, good shout, let me update.

@10upsimon 10upsimon assigned zutigrm and unassigned 10upsimon Sep 30, 2024
@zutigrm
Copy link
Collaborator

zutigrm commented Sep 30, 2024

Thanks @10upsimon IB ✅

@zutigrm zutigrm removed their assignment Sep 30, 2024
@binnieshah binnieshah removed the Next Up Issues to prioritize for definition label Oct 2, 2024
@benbowler benbowler self-assigned this Oct 14, 2024
@benbowler benbowler removed their assignment Oct 14, 2024
@zutigrm zutigrm self-assigned this Oct 14, 2024
@tofumatt tofumatt assigned tofumatt and unassigned zutigrm and tofumatt Oct 14, 2024
@kelvinballoo kelvinballoo self-assigned this Oct 15, 2024
@kelvinballoo
Copy link
Collaborator

QA Update ✅

  • With the adsPAX feature flag disabled the copy is: "Track conversions for your existing Google Ads campaigns"

    Image

  • With the adsPAX feature flag enabled the copy is: "Grow sales, leads or awareness for your business by advertising with Google Ads"

    Image

    Image

@kelvinballoo kelvinballoo removed their assignment Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

6 participants