-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove title borders from Admin Setting Sections #9580
Comments
Thanks @zutigrm AC ✅ Moving to IB and I'll pick this up. |
Thanks @10upsimon IB ✅ |
Can you assign me this issue? |
QA Update ⚠Did a check and here are my observations: ITEM 1: ITEM 2: Other than that, the borders are not appearing, which is as expected. |
@kelvinballoo thank you. I have just pushed a PR that addresses the margin on the Reset Site Kit CTA text. The checkbox vs radio controls can be ignored as part of this issue. |
QA Update ✅Thanks @10upsimon . This was verified good.
|
Feature Description
Borders should be removed from bellow the section titles in the admin settings, and any other edits if needed - like spacing, etc. Figma design can be found here
Currently, boxes with borders:
New design without borders:
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
assets/sass/components/settings/_googlesitekit-settings-admin.scss
admin.scss
file atassets/sass/admin.scss
, within the// Settings
import group..googlesitekit-plugin #js-googlesitekit-settings
and within it:.googlesitekit-layout__header
and remove the boarder, and within it:.mdc-layout-grid
and remove the bottom padding, and within it:h3.googlesitekit-layout__header-title
and set the following CSS properties:font-family: $f-primary;
font-weight: $fw-medium;
font-size: $fs-title-lg;
Test Coverage
QA Brief
Site Kit > Settings > Admin Settings
Changelog entry
The text was updated successfully, but these errors were encountered: