Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect redirect when clicking on 'Learn More' link in Connected Services #9734

Closed
2 tasks done
wpdarren opened this issue Nov 21, 2024 · 2 comments
Closed
2 tasks done
Labels
Good First Issue Good first issue for new engineers Module: Sign in with Google Sign in with Google (SiwG) related issues. P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@wpdarren
Copy link
Collaborator

wpdarren commented Nov 21, 2024

Bug Description

From the SiWG bug bash. Asana ticket can be found here.

On the settings page, when clicking on "learn more" you are redirected to the One Tap section on the Google Developers website, however, you should be redirected to Site Kit's documentation. Site Kit's documentation should include a section on One Tap, which should include a link out to the One Tap Section on Google Developers page.

We'll need to change the in-product link to https://sitekit.withgoogle.com/documentation/using-site-kit/sign-in-with-google#one-tap/


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

  • Update the learn more link URL in OneTapToggle.js
  • Use getDocumentationLinkURL to generate the correct link for the slug defined in the AC

Test Coverage

  • N/A

QA Brief

  • Click the learn more link next to the Sign in with Google one tap toggle and confirm it links to the correct URL in the AC.

Changelog entry

  • Update learn more link in Sign in with Google module settings.
@wpdarren wpdarren added Module: Sign in with Google Sign in with Google (SiwG) related issues. P0 High priority Type: Enhancement Improvement of an existing feature labels Nov 21, 2024
@binnieshah binnieshah added Next Up Issues to prioritize for definition Team S Issues for Squad 1 labels Nov 22, 2024
@eugene-manuilov eugene-manuilov added the Good First Issue Good first issue for new engineers label Nov 26, 2024
@benbowler benbowler self-assigned this Nov 26, 2024
@benbowler benbowler removed their assignment Nov 27, 2024
@10upsimon 10upsimon assigned 10upsimon and unassigned 10upsimon Nov 27, 2024
@aaemnnosttv aaemnnosttv self-assigned this Nov 27, 2024
@aaemnnosttv
Copy link
Collaborator

@eugene-manuilov I'm reviewing this one now, but the IB here missed a mention of the infra to use for generating the right link. The AC should also include this detail regarding the doc ID to use/create.

I'll update it now but please be careful to follow the conventions we have for learn more and get help links.

@aaemnnosttv aaemnnosttv assigned benbowler and unassigned aaemnnosttv Nov 27, 2024
@benbowler benbowler removed their assignment Nov 28, 2024
@binnieshah binnieshah removed the Next Up Issues to prioritize for definition label Nov 28, 2024
@zutigrm zutigrm assigned zutigrm and aaemnnosttv and unassigned zutigrm Dec 2, 2024
@aaemnnosttv aaemnnosttv assigned benbowler and unassigned aaemnnosttv Dec 2, 2024
@benbowler benbowler assigned aaemnnosttv and unassigned benbowler Dec 3, 2024
@aaemnnosttv aaemnnosttv removed their assignment Dec 3, 2024
@wpdarren wpdarren self-assigned this Dec 4, 2024
@wpdarren
Copy link
Collaborator Author

wpdarren commented Dec 4, 2024

QA Update: ✅

Verified:

  • The learn more link for the One Tap setting is updated to lead to the following page: https://sitekit.withgoogle.com/documentation/using-site-kit/sign-in-with-google/#one-tap

  • The URL is defined as a learn more link with a slug of sign-in-with-google-one-tap using common documentation link infrastructure https://sitekit.withgoogle.com/support?doc=sign-in-with-google-one-tap

@wpdarren wpdarren removed their assignment Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good first issue for new engineers Module: Sign in with Google Sign in with Google (SiwG) related issues. P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

8 participants