Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "improve your measurement" section mobile design to match Figma #9830

Closed
1 task
techanvil opened this issue Dec 6, 2024 · 3 comments
Closed
1 task
Labels
P0 High priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature

Comments

@techanvil
Copy link
Collaborator

techanvil commented Dec 6, 2024

Feature Description

We now have a mobile design in Figma for the improve your measurement section. The current implementation should be updated to adhere to this design.

Image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The improve your measurement section on the Analytics settings edit screen should be updated to follow the mobile Figma design.
  • The improve your measurement section on the Ads settings edit screen should also be updated to follow the principles of the above design.

Implementation Brief

  • Update the ConversionTrackingToggle, FirstPartyModeToggle and SettingsGroup styling to match the Figma design.
    • Finish and merge this PR.

Test Coverage

  • Fix any failing tests.

QA Brief

  • View the Ads and Analytics settings edit panels, confirm the new layout matches the designs on all viewports and that the settings still remain functional.

Changelog entry

  • Fix the "improve your measurement" section's layout in mobile viewports.
@techanvil techanvil added P0 High priority Type: Enhancement Improvement of an existing feature labels Dec 6, 2024
@techanvil techanvil self-assigned this Dec 6, 2024
@techanvil techanvil removed their assignment Dec 6, 2024
@aaemnnosttv aaemnnosttv self-assigned this Dec 6, 2024
@aaemnnosttv
Copy link
Collaborator

IB ✅

@aaemnnosttv aaemnnosttv removed their assignment Dec 6, 2024
@benbowler benbowler self-assigned this Dec 9, 2024
@ivonac4 ivonac4 added the Team M Issues for Squad 2 label Dec 9, 2024
@benbowler benbowler removed their assignment Dec 9, 2024
@techanvil techanvil assigned techanvil and benbowler and unassigned techanvil Dec 9, 2024
@benbowler benbowler assigned techanvil and unassigned benbowler Dec 10, 2024
@techanvil techanvil assigned benbowler and unassigned techanvil Dec 10, 2024
@techanvil
Copy link
Collaborator Author

Hi @benbowler, please can you add a QAB for this one?

@benbowler benbowler removed their assignment Dec 10, 2024
@wpdarren wpdarren self-assigned this Dec 10, 2024
@wpdarren
Copy link
Collaborator

QA Update: ✅

Verified:

  • The improve your measurement section on the Analytics settings edit screen is updated to follow the mobile Figma design.
  • The improve your measurement section on the Ads settings edit screen is also updated to follow the principles of the above design.
  • Completed checked on various mobile, tablet and desktop viewports to ensure no styling issues.
Screenshots

Image
Image
Image
Image
Image

@wpdarren wpdarren removed their assignment Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

6 participants