You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
It would be good to add some check in case there are non-image files in an image directory.
Describe the solution you'd like
A simple filter would suffice, e.g.
If not image file:
skip
Describe alternatives you've considered
A: Do nothing - potential for tool to fail while processing data, which could waste user's time
B: Filter at the DataFrame level - best not to propagate errors downstream
Additional context
See client._read_image_directory.
The text was updated successfully, but these errors were encountered:
Additionally, would be beneficial to do better processing of filenames. I had a dataset collected from the internet and it had , or could potentially have ".
Currently I fixed it locally, but could be addressed in the library itself
Hi @lc0 , thanks for the feedback, and apologies for the delay in response. It seems I wasn't getting any notifications for non-PR comments in this repo. That's an interesting idea. I can see how it could simplify parsing since the image files will be in one list. I think it would add a bit more burden to the user to specify a glob instead of just the directory path, but shouldn't be a big deal. We were also thinking of possible supporting other directory structures (e.g. label/image only) for flexibility.
Regarding filename processing, could you elaborate on the problem a bit more and the solution that you came up with? Feel free to send a PR btw and I'll be happy to review it.
It would be good to add some check in case there are non-image files in an image directory.
Describe the solution you'd like
A simple filter would suffice, e.g.
Describe alternatives you've considered
A: Do nothing - potential for tool to fail while processing data, which could waste user's time
B: Filter at the DataFrame level - best not to propagate errors downstream
Additional context
See
client._read_image_directory
.The text was updated successfully, but these errors were encountered: