Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passwords for Docker Container Configuration Should Be Read From File #1126

Closed
einfallstoll opened this issue Mar 10, 2020 · 0 comments
Closed

Passwords for Docker Container Configuration Should Be Read From File #1126

einfallstoll opened this issue Mar 10, 2020 · 0 comments

Comments

@einfallstoll
Copy link
Contributor

einfallstoll commented Mar 10, 2020 •
edited
Loading

Passing password by ENV is bad practice and should be replaced by using docker secrets. To accomplish this, the current environment variables could be extended by POSTGRES_PASSWORD_FILE and TIMESKETCH_PASSWORD_FILE which read the file from the appropriate path (usually /run/secrets/secret-name).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@einfallstoll