Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CloudSpanner log implementation GA #1681

Closed
AlCutter opened this issue Jun 12, 2019 · 4 comments
Closed

Make CloudSpanner log implementation GA #1681

AlCutter opened this issue Jun 12, 2019 · 4 comments
Assignees
Labels

Comments

@AlCutter
Copy link
Member

No description provided.

@AlCutter
Copy link
Member Author

AlCutter commented Jul 3, 2019

Need to document a list of blockers

@RJPercival
Copy link
Contributor

While working on #1772, I came across this graph for Cloud Spanner which indicates lots of already_exists errors for Commit requests and failed_precondition errors for Rollback requests in our CI environment. Presumably this is normal, since the deployment appears to be operating successfully, but I was wondering whether we could do anything to reduce the number of failed_precondition errors since this seems like something we'd otherwise want to alert on?

@AlCutter
Copy link
Member Author

AlCutter commented Jul 15, 2019

Just had a dig into it - it's due to the fact that the CT hammer creates a lot of duplicate submissions.

I've filed #569 to track that, and popped a quick hack into the version of hammer running against spanner CI to disable dupes for the moment.

The linked graph has dropped off to zero now.

@RJPercival
Copy link
Contributor

RJPercival commented Jul 15, 2019

I'm guessing the rollback errors were because we were calling Rollback after Commit when receiving already_exists, which isn't allowed? Thanks for looking into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants