-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI PRP: Apache airflow default credential tester #526
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello @joernNNN. Can you please link the testbed? |
@leonardo-doyensec i updated the first comment to contain the testbeds. |
Hello @joernNNN. Thank you for your contribution. I'm noticing that the plugin is not working correctly. When i try to run the plugin on my side it's not running at all. Can you please check it on your side? Feel free to reach out |
Friendly ping @joernNNN |
@leonardo-doyensec, Thanks for the ping, I totally missed your comment. I'm going to solve this issue today. |
@leonardo-doyensec the plugin is working fine. You must also use the because we are checking whether the service is airflow, we need to do the fingerprinting step before running the weak credential tester plugin. @Override
public boolean canAccept(NetworkService networkService) {
return NetworkServiceUtils.getWebServiceName(networkService).equals(AIRFLOW_SERVICE);
} the command line switches I use and the version of the Tsunami CLI can be seen in the following: java -cp "tsunami-main-0.0.24-SNAPSHOT-cli.jar:/home/joern/tsunami/myPlugins/*" -Dtsunami-config.location=/home/joern/tsunami/tsunami_tcs.yaml com.google.tsunami.main.cli.TsunamiCli --uri-target=http://localhost:8080/ --http-client-trust-all-certificates --scan-results-local-output-format=JSON --scan-results-local-output-filename=/tmp/tsunami-output.json
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @joernNNN
i've noticed that the plugin is working correctly right now. There is just one problem. The plugin tries to bruteforce all the credentials even if the ones from the fingerprint phase are valid. Can you find a way to stop the plugin if those are correct? This will reduce the noise performed by the scan.
Moreover you can find some minor stylistic issue to address.
~ Feel free to reach out
Leonardo (Doyensec)
...ctors/credentials/genericweakcredentialdetector/testers/airflow/AirflowCredentialTester.java
Show resolved
Hide resolved
...ctors/credentials/genericweakcredentialdetector/testers/airflow/AirflowCredentialTester.java
Outdated
Show resolved
Hide resolved
...s/credentials/genericweakcredentialdetector/testers/airflow/AirflowCredentialTesterTest.java
Show resolved
Hide resolved
Hello @leonardo-doyensec @tooryx I would like to know if we can have only the default credentials for a weak credential plugin to brute-force not all other default credentials or top username and password lists. |
According to #521
the testbed:
google/security-testbeds#81