-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable generics in waitFor #130
Comments
Yes. |
the code change is pretty trivial, just uncommenting the generic definitions already in there for the most part, but I have no idea how to get bazel running tests in a Dart 1.21 environment |
dart_rules are currently using 1.21.0-dev.3.0 (https://github.com/dart-lang/rules_dart/blob/master/dart/build_rules/repositories.bzl#L69). Is that not sufficient? |
That should be, when I run bazel test locally this is the type of error I am seeing though:
|
I opened a PR to see if travis-ci does better than local-guy-named-travis #131 |
This was addressed by 131, would you be able to publish a release including this change at your convenience? thanks! @DrMarcII |
Release has been published. |
Thanks! |
For consuming libraries to obey strong mode, we will need to enable the commented-out generics in the waitFor definition here. This would require bumping the SDK restriction to 1.21+. Is this a change you would be open to accepting?
The text was updated successfully, but these errors were encountered: