-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-lint always fails #48
Comments
Thank you for making an issue! Pretty silly oversight on my part, when I was testing this I only tested it on yaml that needed changes, and forgot the test case of a yaml file that's already formatted. 😧 I can get a patch release out for this tomorrow. |
While fixing this I found another thing that I meant to fix on v0.4.0, which is that the multiline diffing always assumed |
Thank you for your quick work! |
v0.5.0 is released! Thank you for your patience and hopefully this works better. |
I confirmed it's been fixed! Thank you! |
I've just started using yamlfmt since v0.4.0, so I don't know how it worked before, but I think this issue was introduced in v0.4.0 because of the new diff library.
https://github.com/RageCage64/multilinediff seems to always return non-empty string but
yamlfmt/engine/engine.go
Line 95 in f3eff05
-lint
always fails even if there's no diff.Similarly,
-dry
always outputs all contents.The text was updated successfully, but these errors were encountered: