Adds walrus test and python 3.7/3.8 tox definitions #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianmego
force-pushed
the
add_walrus_test
branch
from
55274a2 to
0c3d923
Compare
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give a mouse a cookie...
I was looking at this issue: #787
Was curious if lib2to3 supported the walrus operator since the bug was reported (it does: https://bugs.python.org/issue36541#msg365718)
Added a test on the thing, which necessitated adding 3.8 to tox.ini.
Seemed silly to have 3.8 in there but not 3.7, so added that, too.
Also, interestingly enough, the lib2to3 walrus operator support includes 3.7, even though it wasn't introduced until 3.8. I don't think that's a compelling reason to support it in yapf, though.