Ignore end of line # copybara: directives.
#886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylint and pytype end of line comments adjusting their behavior are already handled specially. This does the same for copybara. I don't like that this is turning into a chain of property calls, refactoring this into a single question of "is this end of line comment special" would be better if we gain any more of these. A usual internal comment this will ignore is `# copybara:strip` placed on a long import line for something being excluded by copybara when pushing internally maintained code to upstream to keep internal google-isms from escaping.
|
Thanks. Could you add an entry to |
Yep, done. |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylint and pytype end of line comments adjusting their behavior are
already handled specially. This does the same for copybara.
I don't like that this is turning into a chain of property calls,
refactoring this into a single question of "is this end of line comment
special" would be better if we gain any more of these.
A usual internal comment this will ignore is
# copybara:stripplacedon a long import line for something being excluded by copybara when
pushing internally maintained code to upstream to keep internal
google-isms from escaping.