Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deriving AsBytes on unsized types #121

Open
joshlf opened this issue Nov 3, 2022 · 0 comments
Open

Support deriving AsBytes on unsized types #121

joshlf opened this issue Nov 3, 2022 · 0 comments
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking

Comments

@joshlf
Copy link
Member

joshlf commented Nov 3, 2022 •
edited
Loading

Currently, the code generated by our AsBytes derive includes calls to core::mem::size_of in order to determine whether a type has padding (unless the type is repr(transparent) or repr(packed)). This prevents deriving AsBytes on unsized non-repr(transparent)/repr(packed) types.
@joshlf joshlf assigned joshlf and unassigned joshlf Nov 4, 2022
@joshlf joshlf removed their assignment May 24, 2023
@joshlf joshlf added the compatibility-nonbreaking Changes that are (likely to be) non-breaking label Aug 12, 2023
@joshlf joshlf mentioned this issue Aug 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshlf