Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide users with a way to override call settings #96

Closed
AnashOommen opened this issue Jun 11, 2019 · 1 comment
Closed

Provide users with a way to override call settings #96

AnashOommen opened this issue Jun 11, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request P1 usability This issue is related to a usability issue with the client library.

Comments

@AnashOommen
Copy link
Member

Provide users with a way to override call settings on a per-service level. Right now, this is exposed on a per-call basis only. While that's more granular, it is also a lot of boilerplate code for users. Exposing call settings at service level tries to strike a balance between usability and granularity.

@AnashOommen AnashOommen added enhancement New feature or request P1 usability This issue is related to a usability issue with the client library. labels Jun 11, 2019
@AnashOommen AnashOommen self-assigned this Jun 11, 2019
@AnashOommen
Copy link
Member Author

I added a new code example: https://github.com/googleads/google-ads-dotnet/blob/master/examples/Misc/SetCustomClientTimeouts.cs that shows how to use a custom call-level call setting. Given that this is a reasonably low-friction way of overriding default settings, I don't think there's an additional need to expose this setting on the service level also. Marking as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 usability This issue is related to a usability issue with the client library.
Projects
None yet
Development

No branches or pull requests

1 participant