Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with fromString param and handle errors from parse ini functions #144

Closed
wants to merge 2 commits into from
Closed

Conversation

shakaran
Copy link
Contributor

@shakaran shakaran commented Jul 1, 2016

This PR basically is a small fix for fromString() which never process the right string (it seems a typo in the var for passing the data) and add a extra checking for files INI that could break the configuration loading throwing a exception if invalid errors were found.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@shakaran
Copy link
Contributor Author

shakaran commented Jul 1, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@shakaran
Copy link
Contributor Author

shakaran commented Jul 1, 2016

I also add the fromString function for OAuth2TokenBuilder class. It could be interesting add the fromString function in the interface AdsBuilder so other classes inheriting from AdsBuilder will have to implement this function

@vtsao vtsao self-assigned this Jul 1, 2016
@vtsao vtsao added the beta label Jul 1, 2016
@shakaran
Copy link
Contributor Author

@vtsao when will go this fix merged to experimental? 3 weeks and I don't see any progress just for merge this pull request

@vtsao
Copy link
Contributor

vtsao commented Jul 22, 2016

Fixed in the latest version of experimental:
https://github.com/googleads/googleads-php-lib/tree/experimental

@vtsao vtsao closed this Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants