Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How about namespaces? #167

Closed
mikemeier opened this issue Sep 17, 2016 · 2 comments
Closed

How about namespaces? #167

mikemeier opened this issue Sep 17, 2016 · 2 comments
Assignees
@vtsao
Labels
duplicate

Comments

@mikemeier
Copy link

I try to implement DFP, found this library and then I see, that there are no namespaces. Not even prefixed class-names. What is this? 2010? ;-(
@shakaran
Copy link
Contributor

Hi @mikemeier there are some progress in experimental branch https://github.com/googleads/googleads-php-lib/tree/experimental see issue #4

@vtsao vtsao self-assigned this Sep 19, 2016
@vtsao
Copy link
Contributor

vtsao commented Sep 19, 2016

Thanks @shakaran. That's correct, we have a beta branch of this library currently in development and plan to move it to stable soon. The beta branch uses modern PHP development practices and adheres to various PSR's. Namespacing being one of them.

As @shakaran pointed out, please follow #4 for updates. Thanks.

@vtsao vtsao closed this as completed Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vtsao vtsao

Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shakaran @vtsao @mikemeier