Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Missing requirement "symfony/property-access" #181

Closed
hakimio opened this issue Nov 2, 2016 · 4 comments
Closed

[Experimental] Missing requirement "symfony/property-access" #181

hakimio opened this issue Nov 2, 2016 · 4 comments
Assignees
Labels

Comments

@hakimio
Copy link

hakimio commented Nov 2, 2016

Without "symfony/property-access" I get Fatal error: Class 'Symfony\Component\PropertyAccess\PropertyAccess' not found in adwords-lib-experimental\vendor\symfony\serializer\Normalizer\ObjectNormalizer.php on line 40 when trying to download report data.

I know that "symfony/serializer" lists it as suggested requirement but it's not installed by default.

@vtsao
Copy link
Contributor

vtsao commented Nov 3, 2016

@fiboknacky PTAL

@fiboknacky
Copy link
Member

Hi Tomas,

Thanks for reporting the issue. It does require symfony/property-access for using ObjectNormalizer.
We're migrating from ObjectNormalizer to GetSetMethodNormalizer for the reporting.
This will get aligned with BatchJobs, which also uses GetSetMethodNormalizer, and the lib will require no symfony/property-access anymore.

Before that, you could switch from ObjectNormalizer to GetSetMethodNormalizer in ReportDownloader lines 33 and 72 by yourself.

Cheers,
Knack

@hakimio
Copy link
Author

hakimio commented Nov 4, 2016

Thanks, I'll try that out.

@vtsao
Copy link
Contributor

vtsao commented Dec 22, 2016

Closing due to lack of activity, please reopen if this is still an issue.

@vtsao vtsao closed this as completed Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants