Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit for minimizing layout shift best practices #234

Open
warrengm opened this issue Oct 9, 2020 · 0 comments
Open

Audit for minimizing layout shift best practices #234

warrengm opened this issue Oct 9, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request v1.4 PRs and issues for the v1.4 release

Comments

@warrengm
Copy link
Contributor

warrengm commented Oct 9, 2020

Documentation for minimizing layout shift is up at https://developers.google.com/doubleclick-gpt/guides/minimize-layout-shift. It would be great to audit for some of these best practices on real pages. In particular we could verify that ad slots have some reserved space before being filled. For single-sized slots this size should match the ad size. For multisize it's a bit tricky since there are more tradeoffs. At the very least we should verify that the site is styled to fit the smallest size. (We don't want to audit for the largest size since there are trade-offs between size and blank space or it's possible that the largest size won't fill due to responsive issues)

Technically we want to do this by inspecting computed width/height style on the slot element. More discussion to follow

@warrengm warrengm added the enhancement New feature or request label Oct 9, 2020
@warrengm warrengm added the v1.4 PRs and issues for the v1.4 release label Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.4 PRs and issues for the v1.4 release
Projects
None yet
Development

No branches or pull requests

2 participants