New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream the iframe-elements gatherer #58

Closed

paulirish opened this issue May 16, 2019 · 1 comment · Fixed by GoogleChrome/lighthouse#8979

Collaborator

paulirish commented May 16, 2019

Think its time we can upstream this badboy?

https://github.com/googleads/pub-ads-lighthouse-plugin/blob/master/lighthouse-plugin-ad-speed-insights/gatherers/iframe-elements.js

Contributor

jburger424 commented May 16, 2019

@warrengm is currently working on #55 which modifies it, but that should be in tonight. Will move to the LH repo once that's in.

jburger424 mentioned this issue

core(iframe-elements): Include new IFrameElements gatherer GoogleChrome/lighthouse#8979

Merged

paulirish closed this as completed in GoogleChrome/lighthouse#8979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment