Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-163: lint validate_only optional #1138

Open
toumorokoshi opened this issue Apr 24, 2023 · 2 comments
Open

AIP-163: lint validate_only optional #1138

toumorokoshi opened this issue Apr 24, 2023 · 2 comments

Comments

@toumorokoshi
Copy link
Contributor

AIP-163 notes that validate_only is optional (in the example and lack of text saying required): https://google.aip.dev/163

We should lint for this (or double-check that this isn't covered by some other AIP around request fields being required.

@toumorokoshi
Copy link
Contributor Author

Upon further inspection, I think we can enforce this via a more powerful check enforcing the fields that can be required in a request.

Added one for create with #1142. I'll look at creating one for Get, Update, Delete, and List as well.

@Juneezee
Copy link
Contributor

Juneezee commented Jan 9, 2024

We can close this issue. Already implemented in #1156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants