fix(AIP-121): ignore standard method lookalikes #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
approved these changes
Sep 12, 2023
| @@ -33,16 +33,16 @@ var resourceMustSupportGet = &lint.ServiceRule{ | |||
| // Iterate all RPCs and try to find resources. Mark the | |||
| // resources which have a Get method, and which ones do not. | |||
| for _, m := range s.GetMethods() { | |||
| if utils.IsGetMethod(m) { | |||
| if utils.IsGetMethod(m) && utils.IsResource(utils.GetResponseType(m)) { | |||
There was a problem hiding this comment.
This presumably won't don't oddities like streaming requests or responses, but it's tighter than it was.
There was a problem hiding this comment.
That's a good point, it won't. I might come back for that though, same goes for the Must have List rule as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore methods that look like standard methods but don't actually operate on a resource as a standard method would. This prevents false positive findings related for messages that aren't actually resources but have some standard method lookalikes. Similar to #1235