Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AIP-133): lint http collection ID for lookalikes #1286

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

noahdietz
Copy link
Collaborator

If there is a Custom Method that looks like a Standard Create e.g. CreateAndCheckoutBook, it will have a HTTP suffix like .../books:createAndCheckout. For a resource path like books/{book} this would be valid, sans custom method suffix, because the collection IDs match at the end of the HTTP path, but the rule naively included the custom method suffix and expects the resource pattern to look like books:createAndCheckout. While using Standard Method verbs for Custom Methods is not allowed, it happens occasionally, and ApiLinter shouldn't emit garbage as a result.

Address internal issue.

@noahdietz noahdietz requested a review from a team as a code owner November 9, 2023 17:08
@noahdietz noahdietz added the automerge Summon MOG for automerging label Nov 9, 2023
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Nov 10, 2023
@noahdietz noahdietz merged commit 3397db6 into googleapis:main Nov 13, 2023
6 checks passed
@noahdietz noahdietz deleted the 133-suffix-lookalike branch November 13, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants