fix(AIP-133): lint http collection ID for lookalikes #1286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a Custom Method that looks like a Standard Create e.g.
CreateAndCheckoutBook
, it will have a HTTP suffix like.../books:createAndCheckout
. For a resource path likebooks/{book}
this would be valid, sans custom method suffix, because the collection IDs match at the end of the HTTP path, but the rule naively included the custom method suffix and expects the resource pattern to look likebooks:createAndCheckout
. While using Standard Method verbs for Custom Methods is not allowed, it happens occasionally, and ApiLinter shouldn't emit garbage as a result.Address internal issue.