fix(aip-130): identify standard and custom methods

[liveFreeOrCode]

There is a problem with the Response Message Name linter of AIP-136 currently.

For reference: https://github.com/googleapis/api-linter/blob/main/rules/aip0136/response_message_name.go

This, and all linter methods in aip0136 used a method isCustomMethod. The logic of this method is incomplete/incorrect. It assumed anything with a ":" in it's URI was considered a custom method. But, according to https://google.aip.dev/130, Batch methods are also considered Standard methods. Batch methods have the following URI segments: :batchGet, :batchUpdate, :batchCreate and :batchDelete.

What happens?

service Library {
  // This fails the aip0136 response_message_name lint rule
  rpc BatchDeleteBooks(BatchDeleteBooksRequest) returns (google.protobuf.Empty) {
    option (google.api.http) = {
      post: "/v1/{parent=publishers/*}/books:batchDelete"
      body: "*"
    };
  }
}

[liveFreeOrCode]

Replace was maybe still in here for backwards-compatibility. But do we want that? The current rules don't advocate for Replace methods being standard methods... so why allow it in the latest version of the linter?

[noahdietz]

We can leave it out. Thanks for calling this out.

[liveFreeOrCode]

The History of resource revisions indicates these used to be custom methods, hinting at the fact that they are no longer.

[noahdietz]

Right, AIP-162 is being reworked...technically there are still instances of these methods, but new ones are no longer allowed. Let's roll with this for now, I think they will still pass most custom method rules anyways.

[noahdietz]

Thanks for this, good catch. Good reminder for me that double checking the heuristic(s) used to identify things should be reviewed regularly...while checking for : in the HTTP path, it is incomplete...

[noahdietz]

We can leave it out. Thanks for calling this out.

[noahdietz]

Right, AIP-162 is being reworked...technically there are still instances of these methods, but new ones are no longer allowed. Let's roll with this for now, I think they will still pass most custom method rules anyways.

[jskeet]

(User reported for spam...)