Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AIP-235): allow hosting allow_missing #1416

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

noahdietz
Copy link
Collaborator

Allow hoisting allow_missing to the top level for Batch Delete. It is an allowed field for Standard Delete and it is not necessarily unique to each delete request (like etag), so it can be safely hoisted.

Updates #1404

@noahdietz noahdietz requested a review from a team as a code owner August 8, 2024 23:19
@noahdietz noahdietz requested a review from slevenick August 8, 2024 23:19
@noahdietz noahdietz added the automerge Summon MOG for automerging label Aug 9, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6bfbcdf into googleapis:main Aug 9, 2024
6 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Aug 9, 2024
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 14, 2024
🤖 I have created a release *beep* *boop*
---


## [1.67.2](https://togithub.com/googleapis/api-linter/compare/v1.67.1...v1.67.2) (2024-08-14)


### Bug Fixes

* **AIP-123:** multiword singleton reduction ([#1417](https://togithub.com/googleapis/api-linter/issues/1417)) ([7868552](https://togithub.com/googleapis/api-linter/commit/7868552ff7b27c2fa0f2ff9be3a538763f0450c5))
* **AIP-135:** allow required etag in Delete ([#1414](https://togithub.com/googleapis/api-linter/issues/1414)) ([aa9587b](https://togithub.com/googleapis/api-linter/commit/aa9587bc7184a78109f138c809baa00018ea75e9)), refs [#1395](https://togithub.com/googleapis/api-linter/issues/1395)
* **AIP-235:** allow hosting allow_missing ([#1416](https://togithub.com/googleapis/api-linter/issues/1416)) ([6bfbcdf](https://togithub.com/googleapis/api-linter/commit/6bfbcdfa8858ccdba98760d76e2d2a757855cc7b)), refs [#1404](https://togithub.com/googleapis/api-linter/issues/1404)
* exit rule if response type cannot be resolved ([#1415](https://togithub.com/googleapis/api-linter/issues/1415)) ([6874dab](https://togithub.com/googleapis/api-linter/commit/6874dabb4f0d3503f267bb0ab970d62785d12727)), refs [#1399](https://togithub.com/googleapis/api-linter/issues/1399)


### Documentation

* **AIP-143:** fix rule name used for implementation link ([#1411](https://togithub.com/googleapis/api-linter/issues/1411)) ([f9cf2eb](https://togithub.com/googleapis/api-linter/commit/f9cf2ebc9589abfce88317b1e3318a9e1547b41a))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants