-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for node v12 #490
Comments
This module depends on a native component which depends on nan. |
Just to follow up, the upstream blocker is now closed, and nan is stable on v12. |
@jkwlui -- Is unit testing with Node 12 ready? Basically, does the trampoline image "gcr.io/cloud-devrel-kokoro-resources/node:12-user" exist? |
@JustinBeckwith -- Do you know if unit testing for node 12 is ready? |
We just haven't got there yet. Last time I checked, we had real problems with |
Any updates? |
pprof, which is the module @google-cloud/profiler uses to interact with V8's profilers, does have pre-built binaries available for Node 12. So, you should be able to experiment with using Node 12 and cloud-profiler-nodejs. But, we're still blocked on unit testing for this repo by googleapis/google-cloud-node#2923. |
any upgrade on this? |
We've finished adding unit testing with Node 12 for this repository. |
This was fixed with v3.0.0 |
I'm sure this is already somewhere in the pipeline, but since v12 is the new LTS we're making plans to move sooner rather than later. Could we get a ballpark estimate for when v12 support might land here?
The text was updated successfully, but these errors were encountered: