Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for node v12 #490

Closed
mike-marcacci opened this issue May 18, 2019 · 10 comments
Closed

Add support for node v12 #490

mike-marcacci opened this issue May 18, 2019 · 10 comments
Assignees
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@mike-marcacci
Copy link

I'm sure this is already somewhere in the pipeline, but since v12 is the new LTS we're making plans to move sooner rather than later. Could we get a ballpark estimate for when v12 support might land here?

@nolanmar511
Copy link
Contributor

This module depends on a native component which depends on nan.
For now, support for Node 12 is blocked by nodejs/nan#849.

@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 20, 2019
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Jun 4, 2019
@mike-marcacci
Copy link
Author

mike-marcacci commented Jun 5, 2019

Just to follow up, the upstream blocker is now closed, and nan is stable on v12.

@nolanmar511
Copy link
Contributor

@jkwlui -- Is unit testing with Node 12 ready?

Basically, does the trampoline image "gcr.io/cloud-devrel-kokoro-resources/node:12-user" exist?

@nolanmar511
Copy link
Contributor

@JustinBeckwith -- Do you know if unit testing for node 12 is ready?

@JustinBeckwith
Copy link
Contributor

We just haven't got there yet. Last time I checked, we had real problems with nock, which we use heavily. We are tracking this over here:
googleapis/google-cloud-node#2923

@maxpain
Copy link

maxpain commented Jul 21, 2019

Any updates?

@nolanmar511
Copy link
Contributor

pprof, which is the module @google-cloud/profiler uses to interact with V8's profilers, does have pre-built binaries available for Node 12. So, you should be able to experiment with using Node 12 and cloud-profiler-nodejs.

But, we're still blocked on unit testing for this repo by googleapis/google-cloud-node#2923.

@rokerkony
Copy link

any upgrade on this?

@nolanmar511
Copy link
Contributor

We've finished adding unit testing with Node 12 for this repository.
I'm planning to release this week.

@nolanmar511
Copy link
Contributor

This was fixed with v3.0.0

@google-cloud-label-sync google-cloud-label-sync bot added the api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

6 participants