fix(gengapic): only gen REST client for RESTable services #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
reviewed
Dec 7, 2022
codyoss
reviewed
Dec 7, 2022
codyoss
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix, and introduces the possibility of a breaking change, in generation of clients when
restis a selected transport. If a proto service being generated doesn't have any RPCs withgoogle.api.httpannotations i.e. they are not "REST-able", then a REST client is not generated for the proto service.I've added a sanity check but based on where the code is placed it is really hard to test without setting up the entire generator in code. I have tested this in local generation and with the known example added to
test.sh.