Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): add missing otel deps & resolve patches #1482

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

noahdietz
Copy link
Collaborator

Adds missing otel grpc/http helpers necessary for grpc & http transport wrapper functionality.

Also adds a bunch of gazelle resolve directives to help fix resolution issues that gazelle has with otel modules. According to open-telemetry/opentelemetry-go-contrib#872, there are some weird issues with resolving otel packages between the separate modules and we must explicitly state the resolution mapping in order to actually have the dependency provided to the gazelle generated go_library targets.

Addresses b/333129802

@noahdietz noahdietz requested review from a team as code owners April 5, 2024 23:34
@noahdietz noahdietz merged commit 1f9fa36 into googleapis:main Apr 6, 2024
7 checks passed
@noahdietz noahdietz deleted the missing-otel-dep branch April 6, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants