feat: add dynamic routing header generation #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahdietz
requested changes
Feb 3, 2022
|
Great great start to this Alice! This is a tough feature and you are integrating it marvelously. |
noahdietz
reviewed
Feb 16, 2022
alicejli
force-pushed
the
dynamicRoutingHeader
branch
from
b16ae4c
to
47f9292
Compare
noahdietz
reviewed
Feb 17, 2022
alicejli
force-pushed
the
dynamicRoutingHeader
branch
from
47f9292
to
dcd0642
Compare
noahdietz
approved these changes
Feb 17, 2022
| got = strings.Split(got[0], "&") | ||
| sort.Strings(got) | ||
| sort.Strings(tst.want) | ||
| if !reflect.DeepEqual(got, tst.want) { |
There was a problem hiding this comment.
Nit: use cmp.Diff (look around the codebase for uses) to compare to values in a test. This can be done in another PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the google.api.routing annotation. In short, this annotation allows API producers to explicitly define those request fields should be include in request headers/metadata. Furthermore, it enables API producers to define simple segment matchers (primarily for resource name values) that are generated into regular expressions in the client that extract segments of a field's value to be sent in the header. Finally, it enables API producers to specify a key other than the field name to use in the header key-value-pair. In relation to the implicit headers (extraced from google.api.http annotations), the google.api.routing annotation takes precedence. Please read the annotation documentation for more information on the annotation resolution logic.
gapic-showcaseintegration test