Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gengapic): regapic handle url.Parse error #951

Merged
merged 2 commits into from
Mar 31, 2022
Merged

fix(gengapic): regapic handle url.Parse error #951

merged 2 commits into from
Mar 31, 2022

Conversation

noahdietz
Copy link
Collaborator

Updates regapic code to handle error returned by url.Parse, and refactors the helper generateURLString to accept *httpInfo and return nothing, rather than accept a MethodDescriptorProto to parse httpInfo from and only return an error in that situation (even though every call site has already parse the httpInfo).

@noahdietz noahdietz requested review from a team as code owners March 31, 2022 18:49
@noahdietz noahdietz enabled auto-merge (squash) March 31, 2022 18:58
@noahdietz noahdietz merged commit 098262f into googleapis:main Mar 31, 2022
@release-please release-please bot mentioned this pull request Mar 31, 2022
Merged
@noahdietz noahdietz deleted the refactor-gen-uri branch March 31, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahdietz @codyoss