Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update autogenerated snippet disclaimer #1029

Merged
merged 2 commits into from
Aug 24, 2022
Merged

feat: update autogenerated snippet disclaimer #1029

merged 2 commits into from
Aug 24, 2022

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented Aug 24, 2022

Updates comment disclaimer for autogenerated snippets to the standard disclaimer used across languages for SnippetGen.

The updated comment adds information about the generated samples with link to code example for setting regional API endpoints. The comments are added within the region tag scope so that they show up on the documentation pages.

See similar example for Python: googleapis/gapic-generator-python#1417

@alicejli alicejli requested review from a team as code owners August 24, 2022 15:36
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@alicejli alicejli requested a review from blakeli0 August 24, 2022 17:28
@alicejli alicejli merged commit 16f26f6 into googleapis:main Aug 24, 2022
@alicejli alicejli deleted the updateSnippetDisclaimer branch August 24, 2022 20:28
suztomo pushed a commit that referenced this pull request Dec 16, 2022
* feat: update autogenerated snippet disclaimer

* update integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants