Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add javadoc for ApiFutures #1609

Merged
merged 6 commits into from
Apr 6, 2023
Merged

fix: add javadoc for ApiFutures #1609

merged 6 commits into from
Apr 6, 2023

Conversation

JoeWang1127
Copy link
Collaborator

Fixes #1239 ☕️

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 5, 2023
@JoeWang1127 JoeWang1127 marked this pull request as ready for review April 5, 2023 20:02
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner April 5, 2023 20:02
@JoeWang1127 JoeWang1127 requested a review from burkedavison April 5, 2023 22:12
@JoeWang1127 JoeWang1127 requested a review from blakeli0 April 6, 2023 17:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@burkedavison
Copy link
Member

LGTM

@JoeWang1127 JoeWang1127 merged commit 4bb0a5e into main Apr 6, 2023
@JoeWang1127 JoeWang1127 deleted the fix/ApiFutures-doc branch April 6, 2023 21:06
@release-please release-please bot mentioned this pull request Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison approved these changes

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Javadoc over methods in ApiFutures
3 participants
@JoeWang1127 @burkedavison @blakeli0