feat: enable self signed jwt for http #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
arithmetic1728
force-pushed
the
jwt_http
branch
from
ef7b6e4 to
e84a1b2
Compare
arithmetic1728
added
the
do not merge
tseaver
approved these changes
Sep 30, 2021
arithmetic1728
removed
the
do not merge
vam-google
reviewed
Oct 20, 2021
| Transport == type(self).get_transport_class("grpc") | ||
| or Transport == type(self).get_transport_class("grpc_asyncio") | ||
| ), | ||
| always_use_jwt_access=True, |
There was a problem hiding this comment.
Note, this is still uner if "grpc" condition, but in tests it always assumes it is always_use_jwt_access=True
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable self signed JWT for http so it is now available for all transports.