feat: generate code snippets by default #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
busunkim96
force-pushed
the
busunkim96-patch-1
branch
from
521a497 to
2bf9822
Compare
software-dov
approved these changes
Oct 29, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 29, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [0.54.0](https://www.github.com/googleapis/gapic-generator-python/compare/v0.53.4...v0.54.0) (2021-10-29) ### Features * generate code snippets by default ([#1044](https://www.github.com/googleapis/gapic-generator-python/issues/1044)) ([e46f443](https://www.github.com/googleapis/gapic-generator-python/commit/e46f443dbeffe16b63f97668801b06189769e972)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Oct 29, 2021
busunkim96
added a commit
that referenced
this pull request
Nov 8, 2021
This reverts commit e46f443.
vam-google
pushed a commit
that referenced
this pull request
Nov 8, 2021
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
busunkim96
added a commit
that referenced
this pull request
Feb 3, 2022
Enable snippetgen for the default (non-Ads) templates. This reverts commit 8bdb709 (which was a revert of #1044 and #1055). I've checked that the changes are OK (don't break generation for any APIs) by creating a [tag](https://github.com/googleapis/gapic-generator-python/commits/v0.62.0b1) and running the [presubmit](https://critique.corp.google.com/cl/424921742).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.